os: fix GetInterfaceAddresses memory lieaky

theanarkh · aduh95 · commit a8a1c9a960f4 · 2025-07-24T20:08:34.000+02:00
PR-URL: #58940 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
diff --git a/src/node_os.cc b/src/node_os.cc
@@ -214,6 +214,9 @@ static void GetInterfaceAddresses(const FunctionCallbackInfo<Value>& args) {
     return;
   }
 
+  auto cleanup =
+      OnScopeLeave([&]() { uv_free_interface_addresses(interfaces, count); });
+
   Local<Value> no_scope_id = Integer::New(isolate, -1);
   LocalVector<Value> result(isolate);
   result.reserve(count * 7);
@@ -268,7 +271,6 @@ static void GetInterfaceAddresses(const FunctionCallbackInfo<Value>& args) {
     }
   }
 
-  uv_free_interface_addresses(interfaces, count);
   args.GetReturnValue().Set(Array::New(isolate, result.data(), result.size()));
 }
 

Original file line number	Diff line number	Diff line change
`@@ -214,6 +214,9 @@ static void GetInterfaceAddresses(const FunctionCallbackInfo<Value>& args) {`
`214`	`214`	`return;`
`215`	`215`	`}`
`216`	`216`
	`217`	`+ auto cleanup =`
	`218`	`+ OnScopeLeave([&]() { uv_free_interface_addresses(interfaces, count); });`
	`219`	`+`
`217`	`220`	`Local<Value> no_scope_id = Integer::New(isolate, -1);`
`218`	`221`	`LocalVector<Value> result(isolate);`
`219`	`222`	`result.reserve(count * 7);`
`@@ -268,7 +271,6 @@ static void GetInterfaceAddresses(const FunctionCallbackInfo<Value>& args) {`
`268`	`271`	`}`
`269`	`272`	`}`
`270`	`273`
`271`		`- uv_free_interface_addresses(interfaces, count);`
`272`	`274`	`args.GetReturnValue().Set(Array::New(isolate, result.data(), result.size()));`
`273`	`275`	`}`
`274`	`276`