8000 test: do not check text for engine-generated error · nodejs/node@a4a4819 · GitHub
[go: up one dir, main page]

Skip to content
8000

Commit a4a4819

Browse files
TrottMylesBorins
authored andcommitted
test: do not check text for engine-generated error
In test-tls-wrap-event-emitter, the text of a TypeError is checked as part of the test. However, this text is generated by the JavaScript engine (V8) and not Node.js. Thus, we should not check the text as JS engine error messages can change without it being considered a breaking change for Node.js. A side effect is that node-chakracore will no longer need to patch this test to pass. PR-URL: #19215 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell 8000 @gmail.com>
1 parent 9613e02 commit a4a4819

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/parallel/test-tls-wrap-event-emmiter.js

Lines changed: 1 addition & 1 deletion
< 5045 td data-grid-cell-id="diff-1f3e34630a03d15da40039147e760faecd2607bb2ab8edb0f51172627ccd243e-16-16-2" data-line-anchor="diff-1f3e34630a03d15da40039147e760faecd2607bb2ab8edb0f51172627ccd243eR16" data-selected="false" role="gridcell" style="background-color:var(--bgColor-default);padding-right:24px" tabindex="-1" valign="top" class="focusable-grid-cell diff-text-cell right-side-diff-cell left-side">
assert.throws(
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@ const TlsSocket = require('tls').TLSSocket;
1515
const EventEmitter = require('events').EventEmitter;
1616
1717
() => { new TlsSocket(new EventEmitter()); },
18-
/^TypeError: (.+) is not a function$/
18+
TypeError
1919
);

0 commit comments

Comments
 (0)
0