tools: check tag is on github before release

rvagg · Myles Borins · commit 9f248a4d83c2 · 2016-10-19T14:06:40.000+01:00
PR-URL: #9142 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/tools/release.sh b/tools/release.sh
@@ -78,6 +78,14 @@ function sign {
 
   if [ "${gpgtagkey}" != "${gpgkey}" ]; then
     echo "GPG key for \"${version}\" tag is not yours, cannot sign"
+    exit 1
+  fi
+
+  ghtaggedversion=$(curl -sL https://raw.githubusercontent.com/nodejs/node/${version}/src/node_version.h \
+      | awk '/define NODE_(MAJOR|MINOR|PATCH)_VERSION/{ v = v "." $3 } END{ v = "v" substr(v, 2); print v }')
+  if [ "${version}" != "${ghtaggedversion}" ]; then
+    echo "Could not find tagged version on github.com/nodejs/node, did you push your tag?"
+    exit 1
   fi
 
   shapath=$(ssh ${webuser}@${webhost} $signcmd nodejs $version)
