8000 doc: remove extra using v8::HandleScope statement · nodejs/node@9c59d2f · GitHub
[go: up one dir, main page]
Skip to content

Commit 9c59d2f

Browse files
Christopher J. Brodyrvagg
Christopher J. Brody
authored and
rvagg
committed
doc: remove extra using v8::HandleScope statement
v8::HandleScope does not seem to be required for addon functions. PR-URL: #2983 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
1 parent f010cb5 commit 9c59d2f

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

‎doc/api/addons.markdown‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ First we create a file `hello.cc`:
4444
namespace demo {
4545

4646
using v8::FunctionCallbackInfo;
47-
using v8::HandleScope;
4847
using v8::Isolate;
4948
using v8::Local;
5049
using v8::Object;
@@ -155,7 +154,6 @@ function calls and return a result. This is the main and only needed source
155154

156155
using v8::Exception;
157156
using v8::FunctionCallbackInfo;
158-
using v8::HandleScope;
159157
using v8::Isolate;
160158
using v8::Local;
161159
using v8::Number;
@@ -212,7 +210,6 @@ there. Here's `addon.cc`:
212210

213211
using v8::Function;
214212
using v8::FunctionCallbackInfo;
215-
using v8::HandleScope;
216213
using v8::Isolate;
217214
using v8::Local;
218215
using v8::Null;
@@ -263,7 +260,6 @@ the string passed to `createObject()`:
263260
namespace demo {
264261

265262
using v8::FunctionCallbackInfo;
266-
using v8::HandleScope;
267263
using v8::Isolate;
268264
using v8::Local;
269265
using v8::Object;
@@ -310,7 +306,6 @@ wraps a C++ function:
310306
using v8::Function;
311307
using v8::FunctionCallbackInfo;
312308
using v8::FunctionTemplate;
313-
using v8::HandleScope;
314309
using v8::Isolate;
315310
using v8::Local;
316311
using v8::Object;
@@ -415,7 +410,6 @@ prototype:
415410
using v8::Function;
416411
using v8::FunctionCallbackInfo;
417412
using v8::FunctionTemplate;
418-
using v8::HandleScope;
419413
using v8::Isolate;
420414
using v8::Local;
421415
using v8::Number;
@@ -505,7 +499,6 @@ Let's register our `createObject` method in `addon.cc`:
505499
namespace demo {
506500

507501
using v8::FunctionCallbackInfo;
508-
using v8::HandleScope;
509502
using v8::Isolate;
510503
using v8::Local;
511504
using v8::Object;
@@ -568,7 +561,6 @@ The implementation is similar to the above in `myobject.cc`:
568561
using v8::Function;
569562
using v8::FunctionCallbackInfo;
570563
using v8::FunctionTemplate;
571-
using v8::HandleScope;
572564
using v8::Isolate;
573565
using v8::Local;
574566
using v8::Number;
@@ -668,7 +660,6 @@ In the following `addon.cc` we introduce a function `add()` that can take on two
668660
namespace demo {
669661

670662
using v8::FunctionCallbackInfo;
671-
using v8::HandleScope;
672663
using v8::Isolate;
673664
using v8::Local;
674665
using v8::Number;
@@ -745,7 +736,6 @@ The implementation of `myobject.cc` is similar as before:
745736
using v8::Function;
746737
using v8::FunctionCallbackInfo;
747738
using v8::FunctionTemplate;
748-
using v8::HandleScope;
749739
using v8::Isolate;
750740
using v8::Local;
751741
using v8::Object;

0 commit comments

Comments
 (0)
0