test: make CreateParams stack-allocated

danbev · gibfahn · commit 97a264e194b6 · 2017-12-20T01:59:35.000Z
PR-URL: #17366 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
diff --git a/test/cctest/node_test_fixture.h b/test/cctest/node_test_fixture.h
@@ -59,7 +59,6 @@ class NodeTestFixture : public ::testing::Test {
   static uv_loop_t* CurrentLoop() { return &current_loop; }
 
  protected:
-  v8::Isolate::CreateParams params_;
   v8::Isolate* isolate_;
 
   ~NodeTestFixture() {
@@ -71,6 +70,7 @@ class NodeTestFixture : public ::testing::Test {
     platform_ = new node::NodePlatform(8, &current_loop, nullptr);
     v8::V8::InitializePlatform(platform_);
     v8::V8::Initialize();
+    v8::Isolate::CreateParams params_;
     params_.array_buffer_allocator = allocator_.get();
     isolate_ = v8::Isolate::New(params_);
   }
