lib: remove unnecesary else block

ddazal · BridgeAR · commit 8a85afabba5f · 2020-04-28T13:15:03.000+02:00
The if statement inside the _writeHostObject function returns an expression which makes the else block unnecessary. PR-URL: #32644 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
diff --git a/lib/internal/child_process/serialization.js b/lib/internal/child_process/serialization.js
@@ -25,10 +25,9 @@ class ChildProcessSerializer extends v8.DefaultSerializer {
     if (isArrayBufferView(object)) {
       this.writeUint32(kArrayBufferViewTag);
       return super._writeHostObject(object);
-    } else {
-      this.writeUint32(kNotArrayBufferViewTag);
-      this.writeValue({ ...object });
     }
+    this.writeUint32(kNotArrayBufferViewTag);
+    this.writeValue({ ...object });
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -25,10 +25,9 @@ class ChildProcessSerializer extends v8.DefaultSerializer {`
`25`	`25`	`if (isArrayBufferView(object)) {`
`26`	`26`	`this.writeUint32(kArrayBufferViewTag);`
`27`	`27`	`return super._writeHostObject(object);`
`28`		`- } else {`
`29`		`- this.writeUint32(kNotArrayBufferViewTag);`
`30`		`- this.writeValue({ ...object });`
`31`	`28`	`}`
	`29`	`+ this.writeUint32(kNotArrayBufferViewTag);`
	`30`	`+ this.writeValue({ ...object });`
`32`	`31`	`}`
`33`	`32`	`}`
`34`	`33`