fs: cache non-symlinks in realpathSync.

yallop · evanlucas · commit 6629f8f83f01 · 2017-01-04T10:44:06.000-06:00
Extend `fs.realpathSync` to cache the results for paths that are not symlinks in addition to caching symlink mappings. PR-URL: #10253 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/fs.js b/lib/fs.js
@@ -1532,6 +1532,7 @@ fs.realpathSync = function realpathSync(p, options) {
       var stat = fs.lstatSync(base);
       if (!stat.isSymbolicLink()) {
         knownHard[base] = true;
+        if (cache) cache.set(base, base);
         continue;
       }
 

Original file line number	Diff line number	Diff line change
`@@ -1532,6 +1532,7 @@ fs.realpathSync = function realpathSync(p, options) {`
`1532`	`1532`	`var stat = fs.lstatSync(base);`
`1533`	`1533`	`if (!stat.isSymbolicLink()) {`
`1534`	`1534`	`knownHard[base] = true;`
	`1535`	`+ if (cache) cache.set(base, base);`
`1535`	`1536`	`continue;`
`1536`	`1537`	`}`
`1537`	`1538`