test: fix compiler warning in n-api test

addaleax · MylesBorins · commit 577f327d2c79 · 2018-04-16T17:45:50.000-04:00
Missed in ca786c3. This does not actually affect the outcome because returning `nullptr` or `this` from a constructor has the same effect. Backport-PR-URL: #19447 PR-URL: #12318 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
diff --git a/test/addons-napi/test_constructor/test_constructor.c b/test/addons-napi/test_constructor/test_constructor.c
@@ -40,7 +40,7 @@ napi_value Echo(napi_env env, napi_callback_info info) {
 
 napi_value New(napi_env env, napi_callback_info info) {
   napi_value _this;
-  NAPI_CALL(env, napi_get_cb_info(env, info, NULL, NULL, NULL, &_this));
+  NAPI_CALL(env, napi_get_cb_info(env, info, NULL, NULL, &_this, NULL));
 
   return _this;
 }

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ napi_value Echo(napi_env env, napi_callback_info info) {`
`40`	`40`
`41`	`41`	`napi_value New(napi_env env, napi_callback_info info) {`
`42`	`42`	`napi_value _this;`
`43`		`- NAPI_CALL(env, napi_get_cb_info(env, info, NULL, NULL, NULL, &_this));`
	`43`	`+ NAPI_CALL(env, napi_get_cb_info(env, info, NULL, NULL, &_this, NULL));`
`44`	`44`
`45`	`45`	`return _this;`
`46`	`46`	`}`