tty: fix console printing on Windows

addaleax · addaleax · commit 38fd7902efac · 2018-02-26T23:42:53.000+01:00
This broke writing non-ASCII data to the console on Windows because the result would be codepage-dependent. This partially reverts 8b751f7. Fixes: #18189 Refs: #18019 PR-URL: #18214 Fixes: #18189 Refs: #18019 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/lib/tty.js b/lib/tty.js
@@ -24,7 +24,6 @@
 const util = require('util');
 const net = require('net');
 const { TTY, isTTY } = process.binding('tty_wrap');
-const { makeSyncWrite } = require('internal/net');
 const { inherits } = util;
 const errnoException = util._errnoException;
 const errors = require('internal/errors');
@@ -80,8 +79,6 @@ function WriteStream(fd) {
   // even though it was originally intended to change in v1.0.2 (Libuv 1.2.1).
   // Ref: https://github.com/nodejs/node/pull/1771#issuecomment-119351671
   this._handle.setBlocking(true);
-  this._writev = null;
-  this._write = makeSyncWrite(fd);
 
   var winSize = new Array(2);
   var err = this._handle.getWindowSize(winSize);
