test: fix up N-API error test

Gabriel Schulhof · MylesBorins · commit 21f057754ba8 · 2018-05-08T14:22:25.000-07:00
Replace assert.throws() with an explicit try/catch in order to catch the thrown value and be able to compare it strictly to an expected value. Re: #20428 (comment) PR-URL: #20487 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
diff --git a/test/addons-napi/test_error/test.js b/test/addons-napi/test_error/test.js
@@ -61,16 +61,23 @@ assert.throws(() => {
 }, /^TypeError: type error$/);
 
 function testThrowArbitrary(value) {
-  assert.throws(() => {
-    test_error.throwArbitrary(value);
-  }, value);
+  assert.throws(
+    () => test_error.throwArbitrary(value),
+    (err) => {
+      assert.strictEqual(err, value);
+      return true;
+    });
 }
 
 testThrowArbitrary(42);
 testThrowArbitrary({});
 testThrowArbitrary([]);
 testThrowArbitrary(Symbol('xyzzy'));
 testThrowArbitrary(true);
+testThrowArbitrary('ball');
+testThrowArbitrary(undefined);
+testThrowArbitrary(null);
+testThrowArbitrary(NaN);
 
 common.expectsError(
   () => test_error.throwErrorCode(),
