url: improve isURL detection

anonrig · targos · commit 1b06c1e003ac · 2023-05-12T11:57:08.000+02:00
PR-URL: #47886 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -692,11 +692,14 @@ ObjectDefineProperties(URLSearchParams.prototype, {
  *
  * We use `href` and `protocol` as they are the only properties that are
  * easy to retrieve and calculate due to the lazy nature of the getters.
+ *
+ * We check for auth attribute to distinguish legacy url instance with
+ * WHATWG URL instance.
  * @param {*} self
  * @returns {self is URL}
  */
 function isURL(self) {
-  return Boolean(self?.href && self.protocol);
+  return Boolean(self?.href && self.protocol && self.auth === undefined);
 }
 
 class URL {
diff --git a/test/parallel/test-url-is-url.js b/test/parallel/test-url-is-url.js
@@ -0,0 +1,11 @@
+// Flags: --expose-internals
+'use strict';
+
+require('../common');
+
+const { URL, parse } = require('url');
+const assert = require('assert');
+const { isURL } = require('internal/url');
+
+assert.strictEqual(isURL(new URL('https://www.nodejs.org')), true);
+assert.strictEqual(isURL(parse('https://www.nodejs.org')), false);
