test: fix test-tls-connect-memleak

Trott · targos · commit 194d1955a77d · 2018-07-10T09:04:19.000+02:00
A loop that generates a long array is resulting in a RangeError. Moving to Array.prototype.fill() along with the ** operator instead of using a loop fixes the issue. PR-URL: #21681 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
diff --git a/test/pummel/test-tls-connect-memleak.js b/test/pummel/test-tls-connect-memleak.js
@@ -44,9 +44,7 @@ tls.createServer({
 
 {
   // 2**26 == 64M entries
-  let junk = [0];
-
-  for (let i = 0; i < 26; ++i) junk = junk.concat(junk);
+  const junk = new Array(2 ** 26).fill(0);
 
   const options = { rejectUnauthorized: false };
   tls.connect(common.PORT, '127.0.0.1', options, function() {

Original file line number	Diff line number	Diff line change
`@@ -44,9 +44,7 @@ tls.createServer({`
`44`	`44`
`45`	`45`	`{`
`46`	`46`	`// 2**26 == 64M entries`
`47`		`- let junk = [0];`
`48`		`-`
`49`		`- for (let i = 0; i < 26; ++i) junk = junk.concat(junk);`
	`47`	`+ const junk = new Array(2 ** 26).fill(0);`
`50`	`48`
`51`	`49`	`const options = { rejectUnauthorized: false };`
`52`	`50`	`tls.connect(common.PORT, '127.0.0.1', options, function() {`