src: only open HandleScope when necessary

addaleax · targos · commit 14c3af7f3e0e · 2019-03-27T22:16:12.000+01:00
PR-URL: #26734 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
diff --git a/src/api/callback.cc b/src/api/callback.cc
@@ -79,7 +79,6 @@ InternalCallbackScope::~InternalCallbackScope() {
 void InternalCallbackScope::Close() {
   if (closed_) return;
   closed_ = true;
-  HandleScope handle_scope(env_->isolate());
 
   if (!env_->can_call_into_js()) return;
   if (failed_ && !env_->is_main_thread() && env_->is_stopping()) {
@@ -117,6 +116,7 @@ void InternalCallbackScope::Close() {
     return;
   }
 
+  HandleScope handle_scope(env_->isolate());
   Local<Object> process = env_->process_object();
 
   if (!env_->can_call_into_js()) return;
