Validate property values

jorwoods · jorwoods · commit 79c355af9e34 · 2020-08-14T16:55:38.000-05:00
diff --git a/tableauserverclient/models/data_alert_item.py b/tableauserverclient/models/data_alert_item.py
@@ -1,17 +1,17 @@
 import xml.etree.ElementTree as ET
 
-from .property_decorators import property_not_empty, property_is_enum
+from .property_decorators import property_not_empty, property_is_enum, property_is_boolean
 from .user_item import UserItem
 from .view_item import ViewItem
 
 
 class DataAlertItem(object):
     class Frequency:
-        Once = 'once'
-        Frequently = 'frequently'
-        Hourly = 'hourly'
-        Daily = 'daily'
-        Weekly = 'weekly'
+        Once = 'Once'
+        Frequently = 'Frequently'
+        Hourly = 'Hourly'
+        Daily = 'Daily'
+        Weekly = 'Weekly'
 
     def __init__(self):
         self._id = None
@@ -62,7 +62,7 @@ def public(self):
         return self._public
 
     @public.setter
-    @property_not_empty
+    @property_is_boolean
     def public(self, value):
         self._public = value
 
diff --git a/tableauserverclient/server/request_factory.py b/tableauserverclient/server/request_factory.py
@@ -98,7 +98,7 @@ def update_req(self, alert_item):
         xml_request = ET.Element('tsRequest')
         dataAlert_element = ET.SubElement(xml_request, 'dataAlert')
         dataAlert_element.attrib['subject'] = alert_item.subject
-        dataAlert_element.attrib['frequency'] = alert_item.frequency
+        dataAlert_element.attrib['frequency'] = alert_item.frequency.lower()
         dataAlert_element.attrib['public'] = alert_item.public
 
         owner = ET.SubElement(dataAlert_element, 'owner')
