8000 Fixes, optimizations and additions to WiFi by Eloquence4 · Pull Request #86 · nkolban/esp32-snippets · GitHub
[go: up one dir, main page]
Skip to content

Fixes, optimizations and additions to WiFi #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 26, 2017
Merged

Fixes, optimizations and additions to WiFi #86

merged 5 commits into from
Sep 26, 2017

Conversation

Eloquence4
Copy link
Contributor

No description provided.

@Eloquence4 Eloquence4 changed the title Fix a memory leak in WiFi Fixes, optimizations and additions to WiFi Sep 26, 2017
@nkolban
Copy link
Owner
nkolban commented Sep 26, 2017

I'm seeing a series of additions to these pull-requests ... do you want me to hold off merging them?

nkolban
nkolban reviewed Sep 26, 2017
View reviewed changes
Copy link
Owner
@nkolban nkolban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to check that this->wifiEventHandler is not null before deleting?

nkolban
nkolban reviewed Sep 26, 2017
View reviewed changes
cpp_utils/WiFi.cpp
* @brief Deletes the event handler that was used by the class
*/
WiFi::~WiFi() {
delete wifiEventHandler;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to check that wifiEventHandler isn't null before deleting?

Copy link
Contributor Author
@Eloquence4 Eloquence4 Sep 26, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, C++ does that automatically. If it's null, then delete just does nothing, so the if statement is irrelevant.

@Eloquence4
Copy link
Contributor Author

Nah, code is stable. I make sure my code is stable before i make a commit. You can merge if you want.

@nkolban nkolban merged commit 5151e94 into nkolban:master Sep 26, 2017
@Eloquence4 Eloquence4 deleted the WiFi branch September 27, 2017 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkolban nkolban nkolban left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eloquence4 @nkolban
0