8000 Compatibility issue with Python 3.7 · Issue #116 · nirum-lang/nirum-python · GitHub
[go: up one dir, main page]
Skip to content

Compatibility issue with Python 3.7 #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AiOO opened this issue Feb 28, 2019 · 2 comments
Closed

Compatibility issue with Python 3.7 #116

AiOO opened this issue Feb 28, 2019 · 2 comments

Comments

@AiOO
Copy link
Collaborator
AiOO commented Feb 28, 2019 •
edited
Loading

Since the typing module in Python 3.7 doesn't have TupleMeta class, AttributeError occurs by below line . To support Python 3.7 it should be fixed.

nirum-python/nirum/deserialize.py

Line 203 in 1721295

elif type(cls) is typing.TupleMeta:

relative commit: python/cpython@d911e40#diff-015978a768b517a38abbc0ecdea87f5a
@kanghyojun
Copy link
Member

However, with the higher version of Nirum compiler, deserialize_meta dosen't used anymore. So we should fix compiler code https://github.com/nirum-lang/nirum/blob/0.5-maintenance/src/Nirum/Targets/Python.hs

@kanghyojun
Copy link
Member
kanghyojun commented Feb 28, 2019 •
edited
Loading

Since nirum-lang/nirum#278 was merged, deserialized_meta was deprecated and typing.TupleMeta wasn't used anymore. So I think that there are no bugs if you use the latest version of Nirum compiler. Thanks for your reporting :)
< 6585 input type="hidden" data-csrf="true" name="authenticity_token" value="sRtT3jp0h47eWhjlWcyhDtme+VgnJIsfUkYkz6htfgBF5br0+GE6FqJw7Rz/njeWWVIlMDhPiknU4d/l6kvmEQ==" />

@AiOO AiOO mentioned this issue May 3, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kanghyojun @AiOO
0