Merge tag '0.5.4' into maintenance-0.6

kanghyojun · kanghyojun · commit 81acbbb9805b · 2017-12-09T15:56:43.000+09:00
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -4,7 +4,10 @@ Changelog
 Version 0.6.1
 -------------
 
-To be released.
+To be released
+
+- Made `nirum.datastructures.List` to copy the given value so that
+  it doesn't refer given value's state and is immutable.
 
 
 Version 0.6.0
@@ -72,6 +75,15 @@ Released on July 11, 2017.
 .. _nirum-python-wsgi: https://github.com/spoqa/nirum-python-wsgi
 
 
+Version 0.5.4
+-------------
+
+Released on December 9, 2017.
+
+- Made `nirum.datastructures.List` to copy the given value so that
+  it doesn't refer given value's state and is immutable.
+
+
 Version 0.5.3
 -------------
 
diff --git a/nirum/datastructures.py b/nirum/datastructures.py
@@ -54,7 +54,7 @@ def __repr__(self):
 class List(collections.Sequence):
 
     def __init__(self, items):
-        self.items = items
+        self.items = list(items)
 
     def __getitem__(self, index):
         return self.items[index]
diff --git a/tests/datastructures_test.py b/tests/datastructures_test.py
@@ -88,3 +88,12 @@ def test_list():
     assert immutable_list.count(1) == 1
     assert immutable_list.count(2) == 1
     assert immutable_list.count(3) == 0
+
+
+def test_list_immutable():
+    mutable_list = [1, 2]
+    immutable_list = List(mutable_list)
+    mutable_list.append(3)
+    assert immutable_list.items != mutable_list
+    assert immutable_list.items == [1, 2]
+    assert mutable_list == [1, 2, 3]
