Merge pull request #1415 from bthyreau/mgz_add_ushort

effigies · web-flow · commit e0ae56aff279 · 2025-05-16T05:58:01.000-04:00
Support ushort for the mgh/mgz reader
diff --git a/nibabel/freesurfer/mghformat.py b/nibabel/freesurfer/mghformat.py
@@ -57,11 +57,16 @@
 
 # caveat: Note that it's ambiguous to get the code given the bytespervoxel
 # caveat 2: Note that the bytespervox you get is in str ( not an int)
+# FreeSurfer historically defines codes 0-10 [1], but only a subset is well supported.
+# Here we use FreeSurfer's MATLAB loader [2] as an indication of current support.
+# [1] https://github.com/freesurfer/freesurfer/blob/v8.0.0/include/mri.h#L53-L63
+# [2] https://github.com/freesurfer/freesurfer/blob/v8.0.0/matlab/load_mgh.m#L195-L207
 _dtdefs = (  # code, conversion function, dtype, bytes per voxel
     (0, 'uint8', '>u1', '1', 'MRI_UCHAR', np.uint8, np.dtype('u1'), np.dtype('>u1')),
-    (4, 'int16', '>i2', '2', 'MRI_SHORT', np.int16, np.dtype('i2'), np.dtype('>i2')),
     (1, 'int32', '>i4', '4', 'MRI_INT', np.int32, np.dtype('i4'), np.dtype('>i4')),
     (3, 'float', '>f4', '4', 'MRI_FLOAT', np.float32, np.dtype('f4'), np.dtype('>f4')),
+    (4, 'int16', '>i2', '2', 'MRI_SHORT', np.int16, np.dtype('i2'), np.dtype('>i2')),
+    (10, 'uint16', '>u2', '2', 'MRI_USHRT', np.uint16, np.dtype('u2'), np.dtype('>u2')),
 )
 
 # make full code alias bank, including dtype column
diff --git a/nibabel/freesurfer/tests/test_mghformat.py b/nibabel/freesurfer/tests/test_mghformat.py
@@ -172,11 +172,11 @@ def test_set_zooms():
 
 def bad_dtype_mgh():
     """This function raises an MGHError exception because
-    uint16 is not a valid MGH datatype.
+    float64 is not a valid MGH datatype.
     """
     # try to write an unsigned short and make sure it
     # raises MGHError
-    v = np.ones((7, 13, 3, 22), np.uint16)
+    v = np.ones((7, 13, 3, 22), np.float64)
     # form a MGHImage object using data
     # and the default affine matrix (Note the "None")
     MGHImage(v, None)
