RF: Remove unnecessary call to asbytes for b-prepended strings

jhlegarreta · jhlegarreta · commit d1235a6ef5ea · 2024-06-26T20:43:04.000-04:00
Remove unnecessary call to `asbytes` for `b`-prepended strings: strings prepended with `b` are already treated as bytes literals: - `TckFile.MAGIC_NUMBER` is b'mrtrix tracks' - `TrkFile.MAGIC_NUMBER` is b'TRACK' Documentation: https://docs.python.org/3/reference/lexical_analysis.html#string-and-bytes-literals Fixes: ``` /home/runner/work/nibabel/nibabel/nibabel/streamlines/tests/test_streamlines.py:9: DeprecationWarning: `np.compat`, which was used during the Python 2 to 3 transition, is deprecated since 1.26.0, and will be removed from numpy.compat.py3k import asbytes ``` raised for example at: https://github.com/nipy/nibabel/actions/runs/9637811213/job/26577586721#step:7:178
diff --git a/nibabel/streamlines/tests/test_streamlines.py b/nibabel/streamlines/tests/test_streamlines.py
@@ -6,7 +6,6 @@
 
 import numpy as np
 import pytest
-from numpy.compat.py3k import asbytes
 
 import nibabel as nib
 from nibabel.testing import clear_and_catch_warnings, data_path, error_warnings
@@ -95,7 +94,7 @@ def test_is_supported_detect_format(tmp_path):
     # Valid file without extension
     for tfile_cls in FORMATS.values():
         f = BytesIO()
-        f.write(asbytes(tfile_cls.MAGIC_NUMBER))
+        f.write(tfile_cls.MAGIC_NUMBER)
         f.seek(0, os.SEEK_SET)
         assert nib.streamlines.is_supported(f)
         assert nib.streamlines.detect_format(f) is tfile_cls
@@ -104,7 +103,7 @@ def test_is_supported_detect_format(tmp_path):
     for tfile_cls in FORMATS.values():
         fpath = tmp_path / 'test.txt'
         with open(fpath, 'w+b') as f:
-            f.write(asbytes(tfile_cls.MAGIC_NUMBER))
+            f.write(tfile_cls.MAGIC_NUMBER)
             f.seek(0, os.SEEK_SET)
             assert nib.streamlines.is_supported(f)
             assert nib.streamlines.detect_format(f) is tfile_cls
