[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some Quality Check functionnalities - First is a backgound noise calculation method #988

Open
dmadou opened this issue Feb 11, 2016 · 7 comments
Labels
Good first issue Good for newcomers. Equivalent to "very low" effort.

Comments

@dmadou
Copy link
dmadou commented Feb 11, 2016

Maybe we should add some QC functions to allow users to check basic informations about their input images.
The first method I would like to implement is a background noise calculation method. It would return for each slice of each frame, the standard deviation of the background.

@GaelVaroquaux
Copy link
Member

Other useful function: "check_epi_template_space(epi_img, discrepency_threshold=30)" that would:

  1. compute_epi_mask on the data
  2. resample to the MNI template (obtained with nilearn.datasets.load_mni152_template)
  3. compute a brain mask out of the template (by thresholding it)
  4. Compute a xor between the two masks
  5. (optionaly) erode the result
  6. Threshold on the number of voxels in the resulting array.

This could be displayed in an example showing that ADHD is in template space, but not Haxby.

@aabadie
Copy link
Contributor
aabadie commented Feb 23, 2016

Other useful function: "check_epi_template_space(epi_img, discrepency_threshold=30)"

If nobody is already working on this, I would be happy to have a look.

@GaelVaroquaux
Copy link
Member

@aabadie : I thought that you were busy lately :).

@dmadou is on it actually.

@aabadie
Copy link
Contributor
aabadie commented Feb 23, 2016

I thought that you were busy lately :)

I am but I can always find some time to work on awesome features ;)

@dmadou
Copy link
Author
dmadou commented Feb 23, 2016

@aabadie I can take care of that feature ^^

@aabadie
Copy link
Contributor
aabadie commented Feb 23, 2016

@dmadou sure, go ahead !

@dmadou
Copy link
Author
dmadou commented Mar 1, 2016

Hi everyone,
I implemented the function and when doing so, some questions emerged:

  • Why computing the epi mask before resampling ? That may be in order to save time.
  • In step 3." compute a brain mask out of the template (by thresholding it)", using "compute_epi_mask" or thresholding the template leads to the same brain mask as the template is a zero background image but thresholding is a pretty fast and straighforward process.
  • What does the discrepancy threshold really mean ? Is it a number of voxels or a percentage ?
    Indeed, if it is a number of voxels, it will not have the same meaning when the template itself or its resolution changes.
  • The last one, not that important, is should we allow the user to set the number of iterations when eroding ?
    Thanks for your answers !

@bthirion bthirion added Enhancement for feature requests Good first issue Good for newcomers. Equivalent to "very low" effort. New feature labels Dec 10, 2020
@Remi-Gau Remi-Gau removed Help wanted Enhancement for feature requests labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers. Equivalent to "very low" effort.
Projects
None yet
Development

No branches or pull requests

5 participants