fix reflection type

theofidry · theofidry · commit e437e0408efa · 2016-07-06T17:58:01.000+01:00
diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
@@ -332,8 +332,14 @@ protected function instantiateComplexObject(array &$data, $class, array &$contex
                     }
                 } elseif ($allowed && !$ignored && (isset($data[$key]) || array_key_exists($key, $data))) {
                     $parameterData = $data[$key];
-                    if (null !== $constructorParameter->getClass()) {
-                        $parameterData = $this->serializer->deserialize($parameterData, $constructorParameter->getClass()->getName(), $format, $context);
+                    if (null !== $constructorParameter->getType()) {
+                        try {
+                            $parameterClass = $constructorParameter->getClass()->getName();
+                        } catch (\ReflectionException $e) {
+                            throw new RuntimeException(sprintf('Could not determine the class of the parameter "%s".', $key), 0, $e);
+                        }
+
+                        $parameterData = $this->serializer->deserialize($parameterData, $parameterClass, $format, $context);
                     }
 
                     // Don't run set for a parameter passed to the constructor
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php
@@ -180,6 +180,27 @@ public function testConstructorWithObjectTypeHintDenormalize()
         $this->assertEquals('rab', $obj->getInner()->bar);
     }
 
+    /**
+     * @expectedException \Symfony\Component\Serializer\Exception\RuntimeException
+     * @expectedExceptionMessage Could not determine the class of the parameter "unknown".
+     */
+    public function testConstructorWithUnknownObjectTypeHintDenormalize()
+    {
+        $data = array(
+            'id' => 10,
+            'unknown' => array(
+                'foo' => 'oof',
+                'bar' => 'rab',
+            ),
+        );
+
+        $normalizer = new ObjectNormalizer();
+        $serializer = new DenormalizerDecoratorSerializer($normalizer);
+        $normalizer->setSerializer($serializer);
+
+        $normalizer->denormalize($data, DummyWithConstructorInexistingObject::class);
+    }
+
     public function testGroupsNormalize()
     {
         $classMetadataFactory = new ClassMetadataFactory(new AnnotationLoader(new AnnotationReader()));
@@ -827,3 +848,10 @@ public function getInner()
         return $this->inner;
     }
 }
+
+class DummyWithConstructorInexistingObject
+{
+    public function __construct($id, Unknown $unknown)
+    {
+    }
+}
