extmod/machine_spi: Remove EVENT_POLL_HOOK from soft-SPI transfer func.

dpgeorge · dpgeorge · commit dee47949cc87 · 2017-02-06T14:38:33.000+11:00
SPI needs to be fast, and calling the EVENT_POLL_HOOK every byte makes it
unusable for ports that need to do non-trivial work in the EVENT_POLL_HOOK
call.  And individual SPI transfers should be short enough in time that
EVENT_POLL_HOOK doesn't need to be called.

If something like this proves to be needed in practice then we will need
to introduce separate event hook macros, one for "slow" loops (eg
select/poll) and one for "fast" loops (eg software I2C, SPI).
diff --git a/extmod/machine_spi.c b/extmod/machine_spi.c
@@ -90,12 +90,6 @@ void mp_machine_soft_spi_transfer(mp_obj_base_t *self_in, size_t len, const uint
         if (dest != NULL) {
             dest[i] = data_in;
         }
-
-        // Some ports need a regular callback, but probably we don't need
-        // to do this every byte, or even at all.
-        #ifdef MICROPY_EVENT_POLL_HOOK
-        MICROPY_EVENT_POLL_HOOK;
-        #endif
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -90,12 +90,6 @@ void mp_machine_soft_spi_transfer(mp_obj_base_t *self_in, size_t len, const uint`
`90`	`90`	`if (dest != NULL) {`
`91`	`91`	`dest[i] = data_in;`
`92`	`92`	`}`
`93`		`-`
`94`		`- // Some ports need a regular callback, but probably we don't need`
`95`		`- // to do this every byte, or even at all.`
`96`		`- #ifdef MICROPY_EVENT_POLL_HOOK`
`97`		`- MICROPY_EVENT_POLL_HOOK;`
`98`		`- #endif`
`99`	`93`	`}`
`100`	`94`	`}`
`101`	`95`