8000 add minor logging · nibin/elasticsearch-http-basic@b9a4d21 · GitHub
[go: up one dir, main page]

Skip to content

Commit b9a4d21

Browse files
author
Peter
committed
add minor logging
1 parent 678c4c8 commit b9a4d21

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

src/main/java/com/asquera/elasticsearch/plugins/http/HttpBasicServer.java

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public class HttpBasicServer extends HttpServer {
6363
@Override
6464
public void internalDispatchRequest(final HttpRequest request, final HttpChannel channel) {
6565
if (log)
66-
logger.info("Authorization {}, host {}, xforward {}, path {}, isInWhitelist {}, Client-IP {}, X-Client-IP {}",
66+
logger.info("Authorization:{}, host:{}, xforward:{}, path:{}, isInWhitelist:{}, Client-IP:{}, X-Client-IP:{}",
6767
request.header("Authorization"), request.header("host"),
6868
request.header(xForwardFor), request.path(), isInIPWhitelist(request),
6969
request.header("X-Client-IP"), request.header("Client-IP"));
@@ -75,8 +75,8 @@ public void internalDispatchRequest(final HttpRequest request, final HttpChannel
7575
super.internalDispatchRequest(request, channel);
7676
} else {
7777
String addr = getAddress(request);
78-
Loggers.getLogger(getClass()).error("UNAUTHORIZED type {}, address {}, path {}, request {}, content {}",
79-
request.method(), addr, request.path(), request.params(), request.content().toUtf8());
78+
Loggers.getLogger(getClass()).error("UNAUTHORIZED type:{}, address:{}, path:{}, request:{}, content:{}, credentials:{}",
79+
request.method(), addr, request.path(), request.params(), request.content().toUtf8(), getDecoded(request));
8080
channel.sendResponse(new StringRestResponse(UNAUTHORIZED, "Authentication Required"));
8181
}
8282
}
@@ -86,15 +86,19 @@ private boolean healthCheck(final HttpRequest request) {
8686
return (request.method() == RestRequest.Method.GET) && path.equals("/");
8787
}
8888

89-
public String getDecoded(HttpRequest request) throws IOException {
89+
public String getDecoded(HttpRequest request) {
9090
String authHeader = request.header("Authorization");
9191
if (authHeader == null)
9292
return "";
9393

9494
String[] split = authHeader.split(" ", 2);
9595
if (split.length != 2 || !split[0].equals("Basic"))
9696
return "";
97-
return new String(Base64.decode(split[1]));
97+
try {
98+
return new String(Base64.decode(split[1]));
99+
} catch (IOException ex) {
100+
throw new RuntimeException(ex);
101+
}
98102
}
99103

100104
private boolean authBasic(final HttpRequest request) {
@@ -108,7 +112,7 @@ private boolean authBasic(final HttpRequest request) {
108112
if (this.user.equals(givenUser) && this.password.equals(givenPass))
109113
return true;
110114
}
111-
} catch (IOException e) {
115+
} catch (Exception e) {
112116
logger.warn("Retrieving of user and password failed for " + decoded + " ," + e.getMessage());
113117
}
114118
return false;

0 commit comments

Comments
 (0)
0