Introduced changes to the immutable MatchLabels to the daemonset in #3606 #3976
Description
Describe the bug
The immutable MatchLabels for DaemonSet was changed in #3606 with no override values option defined in the templates which will cause unexpected downtime for production, cause we have to upgrade by deleting and reinstalling.
cannot patch "nginx-ingress-nginx-ingress" with kind DaemonSet: DaemonSet.apps "nginx-ingress-nginx-ingress" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/instance":"nginx-ingress", "app.kubernetes.io/name":"nginx-ingress"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutableTo Reproduce
Upgrade ingress-nginx 3.0.2 to 3.1.1
Expected behavior
Upgrade ingress-nginx (or make some changes in vaules.yaml in advance) to the target version successfully.
Your environment
- Version of the Ingress Controller:
v3.0.2 - Version of Kubernetes:
v1.24.10 - Kubernetes platform (e.g. Mini-kube or GCP):
- Using NGINX or NGINX Plus:
NGINX Plus
Additional context
Revert this changes or keep it be compatible with the previous version would be better. FYI @lucacome