fix: disable batch reload when batch finishes (#6446)

dareste · jjngx · web-flow · commit ea8e46be6158 · 2024-09-23T14:31:29.000+01:00
Co-authored-by: Jakub Jarosz &lt;99677300+jjngx@users.noreply.github.com&gt;
diff --git a/internal/k8s/controller.go b/internal/k8s/controller.go
@@ -916,6 +916,7 @@ func (lbc *LoadBalancerController) sync(task task) {
 		defer lbc.syncLock.Unlock()
 	}
 	if lbc.batchSyncEnabled && task.Kind != endpointslice {
+		glog.V(3).Infof("Task is not endpointslice - enabling batch reload")
 		lbc.enableBatchReload = true
 	}
 	switch task.Kind {
@@ -931,6 +932,7 @@ func (lbc *LoadBalancerController) sync(task task) {
 	case endpointslice:
 		resourcesFound := lbc.syncEndpointSlices(task)
 		if lbc.batchSyncEnabled && resourcesFound {
+			glog.V(3).Infof("Endpointslice %v is referenced - enabling batch reload", task.Key)
 			lbc.enableBatchReload = true
 		}
 	case secret:
@@ -990,7 +992,8 @@ func (lbc *LoadBalancerController) sync(task task) {
 			}
 		}
 
-		glog.V(3).Infof("Batch sync completed")
+		lbc.enableBatchReload = false
+		glog.V(3).Infof("Batch sync completed - disabling batch reload")
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -916,6 +916,7 @@ func (lbc *LoadBalancerController) sync(task task) {`
`916`	`916`	`defer lbc.syncLock.Unlock()`
`917`	`917`	`}`
`918`	`918`	`if lbc.batchSyncEnabled && task.Kind != endpointslice {`
	`919`	`+ glog.V(3).Infof("Task is not endpointslice - enabling batch reload")`
`919`	`920`	`lbc.enableBatchReload = true`
`920`	`921`	`}`
`921`	`922`	`switch task.Kind {`
`@@ -931,6 +932,7 @@ func (lbc *LoadBalancerController) sync(task task) {`
`931`	`932`	`case endpointslice:`
`932`	`933`	`resourcesFound := lbc.syncEndpointSlices(task)`
`933`	`934`	`if lbc.batchSyncEnabled && resourcesFound {`
	`935`	`+ glog.V(3).Infof("Endpointslice %v is referenced - enabling batch reload", task.Key)`
`934`	`936`	`lbc.enableBatchReload = true`
`935`	`937`	`}`
`936`	`938`	`case secret:`
`@@ -990,7 +992,8 @@ func (lbc *LoadBalancerController) sync(task task) {`
`990`	`992`	`}`
`991`	`993`	`}`
`992`	`994`
`993`		`- glog.V(3).Infof("Batch sync completed")`
	`995`	`+ lbc.enableBatchReload = false`
	`996`	`+ glog.V(3).Infof("Batch sync completed - disabling batch reload")`
`994`	`997`	`}`
`995`	`998`	`}`
`996`	`999`