sorted the result of GetDosProtectedThatReferencedDosLogConf in unit test to make it deterministic

ciarams87 · ciarams87 · commit 99b7126a387f · 2021-12-20T18:34:58.000Z
diff --git a/internal/k8s/appprotectdos/app_protect_dos_configuration_test.go b/internal/k8s/appprotectdos/app_protect_dos_configuration_test.go
@@ -1320,6 +1320,9 @@ func TestGetDosProtectedThatReferencedDosLogConf(t *testing.T) {
 	for _, test := range tests {
 		resources := dosConf.GetDosProtectedThatReferencedDosLogConf(test.policyNamespace + "/" + test.policyName)
 		if diff := cmp.Diff(test.expected, resources); diff != "" {
+			sort.SliceStable(resources, func(i, j int) bool {
+				return resources[i].Name < resources[j].Name
+			})
 			t.Errorf("GetDosProtectedThatReferencedDosLogConf() returned unexpected result for the case of: %v (-want +got):\n%s", test.msg, diff)
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -1320,6 +1320,9 @@ func TestGetDosProtectedThatReferencedDosLogConf(t *testing.T) {`
`1320`	`1320`	`for _, test := range tests {`
`1321`	`1321`	`resources := dosConf.GetDosProtectedThatReferencedDosLogConf(test.policyNamespace + "/" + test.policyName)`
`1322`	`1322`	`if diff := cmp.Diff(test.expected, resources); diff != "" {`
	`1323`	`+ sort.SliceStable(resources, func(i, j int) bool {`
	`1324`	`+ return resources[i].Name < resources[j].Name`
	`1325`	`+ })`
`1323`	`1326`	`t.Errorf("GetDosProtectedThatReferencedDosLogConf() returned unexpected result for the case of: %v (-want +got):\n%s", test.msg, diff)`
`1324`	`1327`	`}`
`1325`	`1328`	`}`