8000 use fqdn to support cross namespace ingresses · nginx/kubernetes-ingress@838f3b7 · GitHub
[go: up one dir, main page]
Skip to content

Commit 838f3b7

Browse files
author
Jim Ryan
committed
use fqdn to support cross namespace ingresses
1 parent c0f9877 commit 838f3b7

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

‎internal/configs/ingress.go‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -512,8 +512,9 @@ func createUpstream(ingEx *IngressEx, name string, backend *networking.IngressBa
512512
}
513513

514514
if cfg.UseClusterIP {
515+
fqdn := fmt.Sprintf("%s.%s.svc.cluster.local:%d", backend.Service.Name, ingEx.Ingress.Namespace, backend.Service.Port.Number)
515516
upsServers = append(upsServers, version1.UpstreamServer{
516-
Address: fmt.Sprintf("%s:%d", backend.Service.Name, backend.Service.Port.Number),
517+
Address: fqdn,
517518
MaxFails: cfg.MaxFails,
518519
MaxConns: cfg.MaxConns,
519520
FailTimeout: cfg.FailTimeout,

‎internal/configs/ingress_test.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -700,7 +700,7 @@ func createExpectedConfigForMergeableCafeIngressWithUseClusterIP() version1.Ingr
700700
UpstreamZoneSize: upstreamZoneSize,
701701
UpstreamServers: []version1.UpstreamServer{
702702
{
703-
Address: "coffee-svc:80",
703+
Address: "coffee-svc.default.svc.cluster.local:80",
704704
MaxFails: 1,
705705
MaxConns: 0,
706706
FailTimeout: "10s",
@@ -803,7 +803,7 @@ func createExpectedConfigForCafeIngressWithUseClusterIP() version1.IngressNginxC
803803
UpstreamZoneSize: upstreamZoneSize,
804804
UpstreamServers: []version1.UpstreamServer{
805805
{
806-
Address: "coffee-svc:80",
806+
Address: "coffee-svc.default.svc.cluster.local:80",
807807
MaxFails: 1,
808808
MaxConns: 0,
809809
FailTimeout: "10s",
@@ -817,7 +817,7 @@ func createExpectedConfigForCafeIngressWithUseClusterIP() version1.IngressNginxC
817817
UpstreamZoneSize: upstreamZoneSize,
818818
UpstreamServers: []version1.UpstreamServer{
819819
{
820-
Address: "tea-svc:80",
820+
Address: "tea-svc.default.svc.cluster.local:80",
821821
MaxFails: 1,
822822
MaxConns: 0,
823823
FailTimeout: "10s",

0 commit comments

Comments
 (0)
0