8000 Fine tune Ansible Lint (#342) · nginx/ansible-role-nginx-config@b060d8a · GitHub
[go: up one dir, main page]
Skip to content

Commit b060d8a

Browse files
alessfgalessfg
authored
Fine tune Ansible Lint (#342)
1 parent 47f57e8 commit b060d8a

File tree

5 files changed

+27
-27
lines changed

5 files changed

+27
-27
lines changed

‎.github/workflows/requirements/requirements_ansible.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
---
22
collections:
33
- name: ansible.posix
4-
version: 1.5.2
4+
version: 1.5.4
55
- name: community.general
6-
version: 7.0.1
6+
version: 7.1.0
77
- name: community.crypto # Only required if you plan to to test the NGINX Plus Molecule scenario
8-
version: 2.13.1
8+
version: 2.14.0
99
- name: community.docker # Only required if you plan to use Molecule
10-
version: 3.4.6
10+
version: 3.4.7

‎.github/workflows/requirements/requirements_ansible_lint.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
ansible-core==2.15.0
2-
ansible-compat==3.0.2
2+
# ansible-compat==3.0.2
33
yamllint==1.32.0
44
ansible-lint==6.16.2

‎.github/workflows/requirements/requirements_molecule.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
ansible-core==2.15.0
22
jinja2==3.1.2
3-
ansible-compat==3.0.2
3+
# ansible-compat==3.0.2
44
molecule==5.0.1
55
molecule-plugins[docker]==23.4.1
66
docker==6.1.3

‎CHANGELOG.md‎

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,17 @@
44

55
ENHANCEMENTS:
66

7-
- Bump the Ansible `community.general` collection to `7.0.1`, `ansible.posix` collection to `1.5.2`, `community.crypto` collection to `2.13.1`, and `community.docker` collection to `3.4.6`.
7+
- Bump the Ansible `community.general` collection to `7.1.0`, `ansible.posix` collection to `1.5.4`, `community.crypto` collection to `2.14.0`, and `community.docker` collection to `3.4.7`.
88

99
BUG FIXES:
1010

1111
- The default template now has a proper example value and comment for the `map.mappings` directive.
1212

1313
CI/CD:
1414

15-
- Split Ansible Lint into its own GH actions job since Molecule no longer runs linters natively.
15+
- Split Ansible Lint into its own GitHub Actions job since Molecule no longer runs linters natively.
1616
- Replace `molecule[docker]` with `molecule` and `molecule-plugins[docker]`.
17-
- Explicitly set the `ansible-compat` version.
17+
- Explicitly set the `ansible-compat` version (commented out for the time being whilst waiting for a new release of Molecule).
1818
- Add pre-releases to Release Drafter.
1919

2020
## 0.6.0 (January 29, 2023)
@@ -28,12 +28,12 @@ ENHANCEMENTS:
2828

2929
BUG FIXES:
3030

31-
- GitHub actions should now correctly skip \*plus\* scenarios only when the NGINX Plus license secrets are not present.
32-
- The `ignore-tags` GitHub actions key does not exist. Replace it with the correct key, `tags-ignore`.
31+
- GitHub Actions should now correctly skip \*plus\* scenarios only when the NGINX Plus license secrets are not present.
32+
- The `ignore-tags` GitHub Actions key does not exist. Replace it with the correct key, `tags-ignore`.
3333

3434
TESTS:
3535

36-
- Update GitHub actions to run on Ubuntu 22.04 (and thus support `cgroups` v2).
36+
- Update GitHub Actions to run on Ubuntu 22.04 (and thus support `cgroups` v2).
3737
- Explicitly specify `amd64` as the platform used in NGINX Plus Molecule tests. This will ensure that tests involving NGINX App Protect will work as expected when run on different host architectures (e.g. newer Macbooks with `arm` processors).
3838
- Update the versions of the Ansible NGINX and NGINX App Protect roles used by Molecule.
3939

@@ -53,7 +53,7 @@ Improve the NGINX main config defaults to bring them closer to the standard NGIN
5353

5454
TESTS:
5555

56-
- Update GitHub actions to only skip \*plus\* scenarios when the NGINX Plus license secrets are not present (it used to only run the NGINX Plus test scenarios during internal PRs).
56+
- Update GitHub Actions to only skip \*plus\* scenarios when the NGINX Plus license secrets are not present (it used to only run the NGINX Plus test scenarios during internal PRs).
5757
- Remove Yamllint (Ansible Lint now incorporates Yamllint).
5858
- Skip Ansible Lint line length rules. Slightly refactor code to incorporate changes added to Ansible Lint 6.7.0.
5959

@@ -69,7 +69,7 @@ ENHANCEMENTS:
6969
- Add labels to loops in `tasks/config/template-config.yml` to reduce amount of output data.
7070
- Implement `gunzip`, `map`, `mirror`, `realip` and `split_clients` modules into `http` templates.
7171
- Streamline configuring SELinux.
72-
- Update Dependabot to trigger updates at the same time across all NGINX core roles at the same time and to avoid triggering release drafter on GitHub actions dependency updates.
72+
- Update Dependabot to trigger updates at the same time across all NGINX core roles at the same time and to avoid triggering release drafter on GitHub Actions dependency updates.
7373

7474
BUG FIXES:
7575

@@ -339,19 +339,19 @@ FEATURES:
339339
ENHANCEMENTS:
340340

341341
- Move the `gzip` HTTP config template into the `modules` file. It's a small module and did not warrant being in its own individual file.
342-
- Update Ansible Lint to `5.1.3`, Molecule to `3.4.0`, yamllint to `1.26.3` and Docker Python SDK to `5.0.2`.
342+
- Update Ansible Lint to `5.1.3`, Molecule to `3.4.0`, Yamllint to `1.26.3` and Docker Python SDK to `5.0.2`.
343343
- Consolidate Molecule testing scenarios to address changes introduced in Ansible Lint `5.*`.
344-
- Specify GitHub actions Ubuntu release.
344+
- Specify GitHub Actions Ubuntu release.
345345
- Minor GitHub template tweaks, including the creation of a SECURITY doc.
346346
- Replace Molecule tests using Debian stretch with Debian buster (stretch has reached its EoL), and update list of supported platforms.
347347
- Replace Ansible base with Ansible core. Ansible core will be the "core" Ansible release moving forward from Ansible `2.11`.
348-
- Update GitHub actions to add a workflow dispatch option.
349-
- Update GitHub actions `if` conditionals to use the `contains` function instead of checking for exact names.
348+
- Update GitHub Actions to add a workflow dispatch option.
349+
- Update GitHub Actions `if` conditionals to use the `contains` function instead of checking for exact names.
350350
- Remove Debian Buster from the `plus` Molecule scenario since it often fails in the GitHub Actions CI/CD pipeline.
351351
- Replace "yes"/"no" boolean values with "true"/"false" to comply with YAML spec `1.2`.
352352
- Ensure the default values for the `nginx.conf` template match the default values found on a fresh NGINX installation.
353353
- Change Dependabot frequency from daily to weekly.
354-
- Minor touch-up of GitHub actions workflows.
354+
- Minor touch-up of GitHub Actions workflows.
355355

356356
BUG FIXES:
357357

@@ -373,7 +373,7 @@ ENHANCEMENTS:
373373
- Add support for NGINX GRPC directives.
374374
- Add support for NGINX GZIP directives.
375375
- Add support for upstream server `backup` parameter in http and stream template.
376-
- Only run GitHub actions Galaxy CI/CD workflow when a new release is published.
376+
- Only run GitHub Actions Galaxy CI/CD workflow when a new release is published.
377377
- Update list of supported platforms.
378378
- Update Ansible base to `2.10.5` and Ansible to `2.10.6`.
379379

@@ -387,8 +387,8 @@ BUG FIXES:
387387

388388
ENHANCEMENTS:
389389

390-
- The GitHub actions Molecule CI/CD workflow is no longer run on a new release (this is not necessary since it already runs on every push).
391-
- The GitHub actions Molecule CI/CD workflow should now correctly avoid running 'Plus' related tests on external PRs.
390+
- The GitHub Actions Molecule CI/CD workflow is no longer run on a new release (this is not necessary since it already runs on every push).
391+
- The GitHub Actions Molecule CI/CD workflow should now correctly avoid running 'Plus' related tests on external PRs.
392392
- The `cleanup-config.yml` playbook has been slightly refactored and simplified.
393393
- Update Ansible base to `2.10.4`, Ansible to `2.10.5`, Molecule to `3.2.2` and Docker Python SDK to `4.4.1`.
394394
- Update copyright notice.
@@ -398,7 +398,7 @@ ENHANCEMENTS:
398398
ENHANCEMENTS:
399399

400400
- Update Molecule to `3.2.1` and Docker Python SDK to `4.4.0`.
401-
- Replace TravisCI with GitHub actions.
401+
- Replace TravisCI with GitHub Actions.
402402

403403
BUG FIXES:
404404

@@ -417,7 +417,7 @@ ENHANCEMENTS:
417417

418418
- Add survey to README.
419419
- Improve README structure and use tables where relevant.
420-
- Update Ansible (now Ansible base) to `2.10.3`, Ansible (now Ansible Community Distribution) to `2.10.3`, Ansible Lint to `4.3.7`, Molecule to `3.1.5`, and yamllint to `1.25.0`.
420+
- Update Ansible (now Ansible base) to `2.10.3`, Ansible (now Ansible Community Distribution) to `2.10.3`, Ansible Lint to `4.3.7`, Molecule to `3.1.5`, and Yamllint to `1.25.0`.
421421
- Improve templating of stub status and REST API config.
422422

423423
BUG FIXES:

‎README.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ This role configures NGINX Open Source and NGINX Plus on your target host.
2121
---
2222
collections:
2323
- name: ansible.posix
24-
version: 1.5.2
24+
version: 1.5.4
2525
- name: community.general
26-
version: 7.0.1
26+
version: 7.1.0
2727
- name: community.docker # Only required if you plan to use Molecule (see below)
28-
version: 3.4.6
28+
version: 3.4.7
2929
```
3030
3131
**Note:** You can alternatively install the Ansible community distribution (what is known as the "old" Ansible) if you don't want to manage individual collections.

0 commit comments

Comments
 (0)
0