Use ConcurrentHashMap to store callback so that iterations are thread safe.

yonatann · yonatann · commit b25d74115801 · 2020-04-13T01:38:59.000+03:00
diff --git a/android/src/main/java/com/cloudwebrtc/webrtc/record/AudioSamplesInterceptor.java b/android/src/main/java/com/cloudwebrtc/webrtc/record/AudioSamplesInterceptor.java
@@ -6,7 +6,7 @@
 import org.webrtc.audio.JavaAudioDeviceModule.SamplesReadyCallback;
 import org.webrtc.audio.JavaAudioDeviceModule.AudioSamples;
 
-import java.util.HashMap;
+import java.util.concurrent.ConcurrentHashMap;
 
 /** JavaAudioDeviceModule allows attaching samples callback only on building
  *  We don't want to instantiate VideoFileRenderer and codecs at this step
@@ -17,7 +17,7 @@ public class AudioSamplesInterceptor implements SamplesReadyCallback {
     private int _id;
     private static final String TAG = "AudioSamplesInterceptor";
     @SuppressLint("UseSparseArrays")
-    protected final HashMap<Integer, SamplesReadyCallback> callbacks = new HashMap<>();
+    protected final ConcurrentHashMap<Integer, SamplesReadyCallback> callbacks = new ConcurrentHashMap<>();
 
     public AudioSamplesInterceptor() {
         this._id = id++;
