[iOS] fix removeTrack methodChannel response, onTrack's stream and track not being registered in native. (flutter-webrtc#404)

Ayman-Kortobaa · Ayman-Barghout · web-flow · commit 1a51904248da · 2020-11-05T22:34:03.000+08:00
* [iOS] RemoveTrack result fix for iOS to return BOOL instead of nil as Dart code expects a boolean and throws []"result" called on null.

* [iOS/Darwin] fix issue with video tracks not being registered `Not found video track for RTCMediaStream: {streamId}` in onTrack for Unified-plan as they are not being added to native.

Co-authored-by: Ayman-Barghout &lt;ayman.a.barghout@gmail.com&gt;
diff --git a/common/darwin/Classes/FlutterRTCPeerConnection.m b/common/darwin/Classes/FlutterRTCPeerConnection.m
@@ -545,7 +545,10 @@ - (void)peerConnection:(RTCPeerConnection *)peerConnection
                 }
             }
         }
-        
+
+        peerConnection.remoteTracks[rtpReceiver.track.trackId] = rtpReceiver.track;
+        peerConnection.remoteStreams[mediaStreams[0].streamId] = mediaStreams[0];
+      
         eventSink(event);
     }
 }
diff --git a/common/darwin/Classes/FlutterWebRTCPlugin.m b/common/darwin/Classes/FlutterWebRTCPlugin.m
@@ -680,8 +680,7 @@ - (void)handleMethodCall:(FlutterMethodCall*)call result:(FlutterResult) result
             details:nil]);
             return;
         }
-        [peerConnection removeTrack:sender];
-        result(nil);
+        result(@{@"result": @([peerConnection removeTrack:sender])});
     } else if ([@"addTransceiver" isEqualToString:call.method]){
         NSDictionary* argsMap = call.arguments;
         NSString* peerConnectionId = argsMap[@"peerConnectionId"];

Original file line number	Diff line number	Diff line change
`@@ -545,7 +545,10 @@ - (void)peerConnection:(RTCPeerConnection *)peerConnection`
`545`	`545`	`}`
`546`	`546`	`}`
`547`	`547`	`}`
`548`		`-`
	`548`	`+`
	`549`	`+ peerConnection.remoteTracks[rtpReceiver.track.trackId] = rtpReceiver.track;`
	`550`	`+ peerConnection.remoteStreams[mediaStreams[0].streamId] = mediaStreams[0];`
	`551`	`+`
`549`	`552`	`eventSink(event);`
`550`	`553`	`}`
`551`	`554`	`}`