8000 request update: optimize code · newcoderzhang/LuaViewSDK@dda3e0c · GitHub
[go: up one dir, main page]
Skip to content

Commit dda3e0c

Browse files
author
野松
committed
request update: optimize code
1 parent 6a170db commit dda3e0c

File tree

2 files changed

+24
-4
lines changed

2 files changed

+24
-4
lines changed

‎Android/LuaViewDemo/src/com/taobao/luaview/demo/activity/DemoLuaViewActivity.java

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,16 @@
1010
import com.taobao.luaview.global.LuaScriptLoader;
1111
import com.taobao.luaview.global.LuaView;
1212
import com.taobao.luaview.scriptbundle.ScriptBundle;
13+
import com.taobao.luaview.util.AssetUtil;
1314
import com.taobao.luaview.util.JsonUtil;
1415
import com.taobao.luaview.util.LogUtil;
15-
import com.taobao.luaview.util.LuaUtil;
1616
import com.taobao.luaview.view.LVLoadingDialog;
1717

18-
import org.luaj.vm2.LuaTable;
1918
import org.luaj.vm2.LuaValue;
2019

20+
import java.io.IOException;
21+
import java.io.InputStream;
22+
2123
/**
2224
* 通过LuaView、注入bridge对象，实现Lua-Java通信
2325
*
@@ -70,6 +72,7 @@ public void registerNameBeforeLoad(final LuaView luaView) {
7072
* 加载数据
7173
*/
7274
public void load(final LuaView luaView) {
75+
LogUtil.timeStart("plain code");
7376
luaView.load(getLuaUri(), new LuaScriptLoader.ScriptExecuteCallback() {
7477
@Override
7578
public boolean onScriptPrepared(ScriptBundle bundle) {
@@ -83,6 +86,7 @@ public boolean onScriptCompiled(LuaValue value, LuaValue context, LuaValue view)
8386

8487
@Override
8588
public void onScriptExecuted(String uri, boolean executedSuccess) {
89+
LogUtil.timeEnd("plain code");
8690
//测试调用 lua function
8791
LogUtil.d("call-lua-function return:", luaView.callLuaFunction("global_fun_test1", 1, "a", 0.1));
8892
LogUtil.d("call-lua-function return:", JsonUtil.toString(luaView.callLuaFunction("global_fun_test2", 2, "b", 0.2)));
@@ -92,7 +96,23 @@ public void onScriptExecuted(String uri, boolean executedSuccess) {
9296
});
9397

9498
//load bytecode directly
95-
// luaView.loadAssets("test/lvp/UI_Window.luap");
99+
// LogUtil.timeStart("prototype");
100+
// luaView.loadPrototype(AssetUtil.open(this, "test/lvp/UI_Window.luap"), "UI_window", new LuaScriptLoader.ScriptExecuteCallback() {
101+
// @Override
102+
// public boolean onScriptPrepared(ScriptBundle bundle) {
103+
// return false;
104+
// }
105+
//
106+
// @Override
107+
// public boolean onScriptCompiled(LuaValue value, LuaValue context, LuaValue view) {
108+
// return false;
109+
// }
110+
//
111+
// @Override
112+
// public void onScriptExecuted(String uri, boolean executedSuccess) {
113+
// LogUtil.timeEnd("prototype");
114+
// }
115+
// });
96116
}
97117

98118
/**

‎Android/LuaViewSDK/src/com/taobao/luaview/global/LuaView.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,7 @@ protected void onPostExecute(LuaValue value) {
382382
final LuaValue activity = CoerceJavaToLua.coerce(getContext());
383383
final LuaValue viewObj = CoerceJavaToLua.coerce(LuaView.this);
384384
if (callback == null || callback.onScriptCompiled(value, activity, viewObj) == false) {
385-
executeScript(value, activity, viewObj, null);
385+
executeScript(value, activity, viewObj, callback);
386386
}
387387
}
388388
}.execute();

0 commit comments

Comments
 (0)
0