8000 Discussion: inlining next-aws-lambda vs fixing upstream and other alternatives · Issue #95 · netlify/next-on-netlify · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on May 10, 2021. It is now read-only.
This repository was archived by the owner on May 10, 2021. It is now read-only.
Discussion: inlining next-aws-lambda vs fixing upstream and other alternatives #95
Closed
@lindsaylevine

Description

@lindsaylevine

stakeholders: @FinnWoelm @ehmicky

This issue is to publicly discuss an internal discussion around inlining next-aws-lambda.

Original issues with depending on next-aws-lambda:

  1. plugin dependency issue (Remove npm install next-on-netlify opennextjs/opennextjs-netlify#10) (this is being addressed internally)
  2. miscellaneous user-reported issues

To move forward and relieve some tension with these open issues, we've temporarily inlined next-aws-lambda with Finn's awesome PR. However, @ehmicky brought up concerns around future maintenance issues with inlining.

Options:

  1. Inline the package (most fine-grained control but needing to repeatedly update a semi-active project)
  2. Use patch-package
  3. Fork the project (monorepo though)
  4. Open PRs upstream (this could benefit both the greater Next.js community and other Netlify plugins)

While we all agree inlining is a great first step and improvement from what we had for the original issues, let's try to align on the best path forward.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0