fix: disallow empty key (#134)

Skn0tt · web-flow · commit a8b4a23b8414 · 2024-01-11T13:21:03.000+01:00
diff --git a/src/main.test.ts b/src/main.test.ts
@@ -781,6 +781,7 @@ describe('set', () => {
         siteID,
       })
 
+      expect(async () => await blobs.set('', 'value')).rejects.toThrowError('Blob key must not be empty.')
       expect(async () => await blobs.set('/key', 'value')).rejects.toThrowError(
         'Blob key must not start with forward slash (/).',
       )
diff --git a/src/store.ts b/src/store.ts
@@ -307,6 +307,10 @@ export class Store {
   }
 
   private static validateKey(key: string) {
+    if (key === '') {
+      throw new Error('Blob key must not be empty.')
+    }
+
     if (key.startsWith('/') || key.startsWith('%2F')) {
       throw new Error('Blob key must not start with forward slash (/).')
     }

Original file line number	Diff line number	Diff line change
`@@ -781,6 +781,7 @@ describe('set', () => {`
`781`	`781`	`siteID,`
`782`	`782`	`})`
`783`	`783`
	`784`	`+ expect(async () => await blobs.set('', 'value')).rejects.toThrowError('Blob key must not be empty.')`
`784`	`785`	`expect(async () => await blobs.set('/key', 'value')).rejects.toThrowError(`
`785`	`786`	`'Blob key must not start with forward slash (/).',`
`786`	`787`	`)`
Original file line number	Diff line number	Diff line change
`@@ -307,6 +307,10 @@ export class Store {`
`307`	`307`	`}`
`308`	`308`
`309`	`309`	`private static validateKey(key: string) {`
	`310`	`+ if (key === '') {`
	`311`	`+ throw new Error('Blob key must not be empty.')`
	`312`	`+ }`
	`313`	`+`
`310`	`314`	`if (key.startsWith('/') \|\| key.startsWith('%2F')) {`
`311`	`315`	`throw new Error('Blob key must not start with forward slash (/).')`
`312`	`316`	`}`