Merge pull request python-gitlab#838 from python-gitlab/pickle-fix

max-wittig · web-flow · commit f0e3daadb7f6 · 2019-07-21T21:15:48.000+02:00
fix: improve pickle support
diff --git a/gitlab/base.py b/gitlab/base.py
@@ -52,7 +52,7 @@ def __getstate__(self):
     def __setstate__(self, state):
         module_name = state.pop("_module_name")
         self.__dict__.update(state)
-        self._module = importlib.import_module(module_name)
+        self.__dict__["_module"] = importlib.import_module(module_name)
 
     def __getattr__(self, name):
         try:
diff --git a/gitlab/tests/test_base.py b/gitlab/tests/test_base.py
@@ -93,6 +93,7 @@ def test_pickability(self):
         self.assertIsInstance(unpickled, FakeObject)
         self.assertTrue(hasattr(unpickled, "_module"))
         self.assertEqual(unpickled._module, original_obj_module)
+        pickled2 = pickle.dumps(unpickled)
 
     def test_attrs(self):
         obj = FakeObject(self.manager, {"foo": "bar"})
