ArduinoOTA endless loop (espressif#1533)

lbernstone · me-no-dev · commit cde668dada2e · 2018-06-27T09:06:02.000+02:00
* Changed pinmap to show pins34-39 as GPI

* ArduinoOTA could have endless loop b/c udp.read can return negative result
diff --git a/libraries/ArduinoOTA/src/ArduinoOTA.cpp b/libraries/ArduinoOTA/src/ArduinoOTA.cpp
@@ -149,13 +149,13 @@ int ArduinoOTAClass::parseInt(){
 
 String ArduinoOTAClass::readStringUntil(char end){
     String res = "";
-    char value;
+    int value;
     while(true){
         value = _udp_ota.read();
-        if(value == '\0' || value == end){
+        if(value <= 0 || value == end){
             return res;
         }
-        res += value;
+        res += (char)value;
     }
     return res;
 }

Original file line number	Diff line number	Diff line change
`@@ -149,13 +149,13 @@ int ArduinoOTAClass::parseInt(){`
`149`	`149`
`150`	`150`	`String ArduinoOTAClass::readStringUntil(char end){`
`151`	`151`	`String res = "";`
`152`		`- char value;`
	`152`	`+ int value;`
`153`	`153`	`while(true){`
`154`	`154`	`value = _udp_ota.read();`
`155`		`- if(value == '\0' \|\| value == end){`
	`155`	`+ if(value <= 0 \|\| value == end){`
`156`	`156`	`return res;`
`157`	`157`	`}`
`158`		`- res += value;`
	`158`	`+ res += (char)value;`
`159`	`159`	`}`
`160`	`160`	`return res;`
`161`	`161`	`}`