8000 esp32/boards: Remove all IDF3 variants. · mzdaniel/micropython@b704ff6 · GitHub
[go: up one dir, main page]

Skip to content

Commit b704ff6

Browse files
mattytrentinidpgeorge
authored andcommitted
esp32/boards: Remove all IDF3 variants.
IDF 3 builds are very old now (it seems like the last successful builds are from 2021), and the current IDF 5 is stable. So remove IDF 3 variants. Signed-off-by: Matt Trentini <matt.trentini@gmail.com>
1 parent ad38299 commit b704ff6

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

ports/esp32/boards/ESP32_GENERIC/board.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
"thumbnail": "",
1717
"url": "https://www.espressif.com/en/products/modules",
1818
"variants": {
19-
"IDF3": "Compiled with IDF 3.x",
2019
"D2WD": "ESP32 D2WD",
2120
"SPIRAM": "Support for SPIRAM / WROVER",
2221
"UNICORE": "ESP32 Unicore",

ports/esp32/boards/UM_TINYPICO/board.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,5 @@
2222
"product": "TinyPICO",
2323
"thumbnail": "",
2424
"url": "https://www.tinypico.com/",
25-
"variants": {
26-
"IDF3": "Compiled with IDF 3.x"
27-
},
2825
"vendor": "Unexpected Maker"
2926
}

tools/autobuild/build-boards.sh

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,8 @@ function build_board {
5555
$MICROPY_AUTOBUILD_MAKE BOARD=$board BUILD=$build_dir && copy_artefacts $dest_dir $descr $fw_tag $build_dir $@
5656
rm -rf $build_dir
5757

58-
# Query variants from board.json and build them. Ignore the special "IDF3"
59-
# variant for ESP32 boards (this allows the downloads page to still have
60-
# the idf3 files for older releases that used to be explicitly built).
61-
for variant in `cat $board_json | python3 -c "import json,sys; print(' '.join(v for v in json.load(sys.stdin).get('variants', {}).keys() if v != 'IDF3'))"`; do
58+
# Query variants from board.json and build them.
59+
for variant in `cat $board_json | python3 -c "import json,sys; print(' '.join(json.load(sys.stdin).get('variants', {}).keys()))"`; do
6260
local variant_build_dir=$build_dir-$variant
6361
echo "building variant $descr $board $variant"
6462
$MICROPY_AUTOBUILD_MAKE BOARD=$board BOARD_VARIANT=$variant BUILD=$variant_build_dir && copy_artefacts $dest_dir $descr-$variant $fw_tag $variant_build_dir $@

0 commit comments

Comments
 (0)
0