Update CachedProcedure.cs (#1432)

SolacomYongYao · bgrainger · web-flow · commit 8fffc068247d · 2024-01-08T09:32:35.000-08:00
Fix InvalidCastException when using StoredProcedure with MySQL 5.0

Signed-off-by: Yong Yao &lt;yong.yao@comtechtel.com&gt;
Signed-off-by: Bradley Grainger &lt;bgrainger@gmail.com&gt;
Co-authored-by: Bradley Grainger &lt;bgrainger@gmail.com&gt;
diff --git a/src/MySqlConnector/Core/CachedProcedure.cs b/src/MySqlConnector/Core/CachedProcedure.cs
@@ -30,12 +30,15 @@ internal sealed class CachedProcedure
 				if (!exists)
 					return null;
 
-				var parametersSqlBytes = (byte[]) reader.GetValue(0);
-				var returnsSqlBytes = (byte[]) reader.GetValue(1);
-
 				// ASSUME this is UTF-8 encoded; it's possible that the `character_set_client` column would need to be used?
+				var parametersSqlBytes = (byte[]) reader.GetValue(0);
 				var parametersSql = Encoding.UTF8.GetString(parametersSqlBytes);
-				var returnsSql = Encoding.UTF8.GetString(returnsSqlBytes);
+
+				var returnsSql = reader.GetValue(1) switch
+				{
+					string s => s,
+					object o => Encoding.UTF8.GetString((byte[]) o),
+				};
 
 				var parsedParameters = ParseParameters(parametersSql);
 				if (returnsSql.Length != 0)
