BUG#36167880: Massive memory leak mysqlx native Protobuf adding to collection

oscpache · oscpache · commit feb79798c150 · 2024-03-08T14:35:43.000-06:00
Change-Id: I21e33c83005c29d63d6608236cce0d1a0e69c868
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -17,6 +17,7 @@ v8.4.0
 - WL#16127: Remove the FIDO authentication mechanism
 - WL#16053: Support GSSAPI/Kerberos authentication on Windows using authentication_ldap_sasl_client plug-in for C-extension
 - BUG#36227964: Improve OpenTelemetry span coverage
+- BUG#36167880: Massive memory leak mysqlx native Protobuf adding to collection
 
 v8.3.0
 ======
diff --git a/mysqlx-connector-python/src/mysqlxpb/mysqlxpb.cc b/mysqlx-connector-python/src/mysqlxpb/mysqlxpb.cc
@@ -430,6 +430,7 @@ static void AddPyListToMessageRepeatedMessage(
         return;
       }
       mutable_field.Add(*msg);
+      delete msg;
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -430,6 +430,7 @@ static void AddPyListToMessageRepeatedMessage(`
`430`	`430`	`return;`
`431`	`431`	`}`
`432`	`432`	`mutable_field.Add(*msg);`
	`433`	`+ delete msg;`
`433`	`434`	`}`
`434`	`435`	`}`
`435`	`436`	`}`