show error message if issue with subtasks

ShMcK · ShMcK · commit b682318ee2ef · 2020-07-24T21:55:43.000-07:00
Signed-off-by: shmck &lt;shawn.j.mckay@gmail.com&gt;
diff --git a/web-app/src/containers/Tutorial/formatLevels.ts b/web-app/src/containers/Tutorial/formatLevels.ts
@@ -45,20 +45,33 @@ const formatLevels = ({ progress, position, levels, testStatus }: Input): Output
         status = 'ACTIVE'
       }
       if (step.subtasks && step.subtasks) {
-        subtasks = step.subtasks.map((subtask: string, subtaskIndex: number) => {
-          let subtaskStatus: T.ProgressStatus = 'INCOMPLETE'
-          // task is complete, subtasks must be complete
-          if (status === 'COMPLETE') {
-            subtaskStatus = 'COMPLETE'
-            // task is active, check which are complete from test results
-          } else if (status === 'ACTIVE') {
-            subtaskStatus = !!(testStatus?.summary && testStatus.summary[subtaskIndex]) ? 'COMPLETE' : 'ACTIVE'
-          }
-          return {
-            name: subtask,
-            status: subtaskStatus,
-          }
-        })
+        if (Object.keys(testStatus?.summary || {}).length !== step.subtasks.length) {
+          // test result count and subtask count don't match
+          // something is wrong with the tutorial
+          // NOTE: hacky temp solution as should be caught by tutorial creators / build tools
+          subtasks = [
+            {
+              name:
+                'ERROR: subtasks and test results have a different number of results. This is likely an error with the tutorial.',
+              status: 'ACTIVE' as 'ACTIVE',
+            },
+          ]
+        } else {
+          subtasks = step.subtasks.map((subtask: string, subtaskIndex: number) => {
+            let subtaskStatus: T.ProgressStatus = 'INCOMPLETE'
+            // task is complete, subtasks must be complete
+            if (status === 'COMPLETE') {
+              subtaskStatus = 'COMPLETE'
+              // task is active, check which are complete from test results
+            } else if (status === 'ACTIVE') {
+              subtaskStatus = !!(testStatus?.summary && testStatus.summary[subtaskIndex]) ? 'COMPLETE' : 'ACTIVE'
+            }
+            return {
+              name: subtask,
+              status: subtaskStatus,
+            }
+          })
+        }
       }
       return { ...step, status, subtasks }
     }),
