fix(starlette): Fix failed_request_status_codes=[] (getsentry#3561)

szokeasaurusrex · szokeasaurusrex · commit 09c6f2a898e9 · 2024-09-24T13:38:59.000+02:00
Passing an empty list for `failed_request_status_codes` should result in no status codes resulting in a Sentry error. However, right now, setting `failed_request_status_codes=[]` instead yields the default `failed_request_status_codes` of `range(500, 599)`. This change fixes the incorrect behavior and adds tests to verify the fix.
diff --git a/sentry_sdk/integrations/starlette.py b/sentry_sdk/integrations/starlette.py
@@ -88,9 +88,11 @@ def __init__(
             )
         self.transaction_style = transaction_style
         self.middleware_spans = middleware_spans
-        self.failed_request_status_codes = failed_request_status_codes or [
-            range(500, 599)
-        ]
+        self.failed_request_status_codes = (
+            [range(500, 599)]
+            if failed_request_status_codes is None
+            else failed_request_status_codes
+        )  # type: list[HttpStatusCodeRange]
 
     @staticmethod
     def setup_once():
diff --git a/tests/integrations/starlette/test_starlette.py b/tests/integrations/starlette/test_starlette.py
@@ -1149,6 +1149,7 @@ def test_span_origin(sentry_init, capture_events):
         ([range(400, 403), 500, 501], 405, False),
         ([range(400, 403), 500, 501], 501, True),
         ([range(400, 403), 500, 501], 503, False),
+        ([], 500, False),
     ],
 )
 """Test cases for configurable status codes.

Original file line number	Diff line number	Diff line change
`@@ -1149,6 +1149,7 @@ def test_span_origin(sentry_init, capture_events):`
`1149`	`1149`	`([range(400, 403), 500, 501], 405, False),`
`1150`	`1150`	`([range(400, 403), 500, 501], 501, True),`
`1151`	`1151`	`([range(400, 403), 500, 501], 503, False),`
	`1152`	`+ ([], 500, False),`
`1152`	`1153`	`],`
`1153`	`1154`	`)`
`1154`	`1155`	`"""Test cases for configurable status codes.`