ref(bottle): Delete never-reached code (getsentry#3605)

szokeasaurusrex · web-flow · commit 033e3adb30b0 · 2024-10-04T08:42:45.000Z
The `prepared_callback` should never raise an `HTTPResponse` exception because `prepared_callback` is already decorated by Bottle using a `@route` decorator (or a decorator for the specific HTTP methods, e.g. `@get`). This decorated function never raises `HTTPResponse`, because the `@route` wrapper [captures any `HTTPResponse` exception and converts it into the return value](https://github.com/bottlepy/bottle/blob/cb36a7d83dc560e81dd131a365ee09db2f756a52/bottle.py#L2006-L2009). So, we do not need this code and should delete it.
diff --git a/sentry_sdk/integrations/bottle.py b/sentry_sdk/integrations/bottle.py
@@ -30,7 +30,6 @@
         Bottle,
         Route,
         request as bottle_request,
-        HTTPResponse,
         __version__ as BOTTLE_VERSION,
     )
 except ImportError:
@@ -114,8 +113,6 @@ def wrapped_callback(*args, **kwargs):
 
                 try:
                     res = prepared_callback(*args, **kwargs)
-                except HTTPResponse:
-                    raise
                 except Exception as exception:
                     event, hint = event_from_exception(
                         exception,
