8000 Develop agents fix Updates by riedde · Pull Request #1435 · music-encoding/music-encoding · GitHub
[go: up one dir, main page]

Skip to content

Develop agents fix Updates #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 17 commits into
base: develop-agents-fix
Choose a base branch
from

Conversation

riedde
Copy link
Contributor
@riedde riedde commented Feb 28, 2024

This is a PR for revising the code after a complex merge @bwbohl and I did.
closes #1434

TODO:

  • update documentation (text) done at 4b38495
  • update documentation (examples) done at 708cc66

@github-actions github-actions bot added Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically) Component: Core Schema changes to source/modules/* (assigned automatically) labels Feb 28, 2024
@riedde riedde self-assigned this Apr 11, 2024
@riedde
Copy link
Contributor Author
riedde commented Apr 11, 2024

For documentation purpose concerning 06ed7e3

During the March-meeting of @music-encoding/ig-metadata it was noticed that deleting the <editor> element will have multiple and mostly bad side-effects. (starting by language caused issues like "editor" in german is not the same than "editor" in english, or is an editor a creator or contributor? and so on...)
The result of the discussion was that keeping the editor-element would be best.

@riedde
Copy link
Contributor Author
riedde commented Apr 11, 2024

In todays meeting of @music-encoding/ig-metadata we figured out that the elements <funder> and <sponsor> should be kept also because they do not fit into the <creator>/<contributor> model at all. (Resored at 2e31a64)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Schema changes to source/modules/* (assigned automatically) Component: Guidelines & Documentation changes to source: docs, examples or web (assigned automatically)
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

2 participants
0