8000 small fixes · muses-code-js/js-intro-workshop@275b504 · GitHub
[go: up one dir, main page]

Skip to content

Commit 275b504

Browse files
committed
small fixes
1 parent 9d309ac commit 275b504

File tree

8 files changed

+9
-13
lines changed

8 files changed

+9
-13
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ An introductory JavaScript workshop for beginners.
44

55
## Slides
66

7-
Check on slides, click [here](https://docs.google.com/presentation/d/137Q_qJ60GE5cTpKzBodfbzSVhp--jPi4x3N9hxQKAyA/edit?usp=sharing)
7+
Check on slides, click [here](https://goo.gl/5HNvxD)
88

99

1010
## Feedback

cheat-sheet.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ It repeats code over and over again until som 8000 e condition is met.
100100
This loop is similar to ‘while loop’, just with a set amount of repetition. You declare counter in the statement as so:
101101

102102
```
103-
for (var i = 0; i < 5; i++) {
103+
for (let i = 0; i < 5; i++) {
104104
do something 5 times
105105
}
106106
```

css/main.css

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,8 @@ body {
1212
background: #EFEFEF;
1313
display: flex;
1414
flex-direction: column;
15-
font-family: 'Source Sans Pro', sans-serif;
16-
font-size: 100%;
15+
font-family: Avenir, 'Source Sans Pro', sans-serif;
1716
justify-content: center;
18-
min-height: 100vh;
19-
color: #464646;
2017
}
2118

2219
body * {
@@ -30,13 +27,13 @@ header {
3027
}
3128

3229
h1 {
33-
font-family: 'GFS Didot', serif;
30+
font-family: Didot, 'GFS Didot', serif;
3431
font-size: 5rem;
3532
margin: 0 3.5rem;
3633
}
3734

3835
h2 {
39-
font-family: 'GFS Didot', serif;
36+
font-family: Didot, 'GFS Didot', serif;
4037
font-size: 4rem;
4138
margin: 0 3rem;
4239
}
@@ -82,11 +79,10 @@ footer {
8279
}
8380

8481
footer > div {
85-
background-color: #7986e5;
8682
color: white;
8783
display: flex;
8884
flex-direction: row;
89-
font-family: 'Source Sans Pro', sans-serif;
85+
font-family: Avenir, 'Source Sans Pro', sans-serif;
9086
font-size: 1.4rem;
9187
justify-content: space-between;
9288
margin: 0 auto;

img/logo.png

-11.6 KB
Binary file not shown.

img/logo_muses_color.png

-12.6 KB
Binary file not shown.

img/woman.jpg

-39.3 KB
Binary file not shown.

index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ <h2>Let's do some interactive coding today!</h2>
4646
<ul>
4747
<li class="website">
4848
<span>Website:</span>
49-
<a href="http://musescodejs.org" target="_blank" rel="noopener noreferrer">musescodejs.org</a>
49+
<a href="https://musescodejs.org" target="_blank" rel="noopener noreferrer">musescodejs.org</a>
5050
</li>
5151
<li class="email">
5252
<span>e-mail:</span>

js/level1.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@
248248
249249
Example:
250250
251-
let number = 7;
251+
const number = 7;
252252
if (number > 7) {
253253
console.log('Our number is bigger than 7');
254254
} else {
@@ -357,7 +357,7 @@
357357
358358
// the result of a comparison is a Boolean value, so we can
359359
// save it to a variable
360-
var bool = (1 < 2);
360+
const bool = (1 < 2);
361361
console.log(bool);
362362
console.log(!bool); // "not true", therefore false
363363
console.log(bool); // the original value isn't affected

0 commit comments

Comments
 (0)
0