[Profiler] Add function to get parent token directly

stloyd · stloyd · commit 9daa2a6cc8e0 · 2011-12-23T09:45:13.000+01:00
diff --git a/src/Symfony/Component/HttpKernel/Profiler/FileProfilerStorage.php b/src/Symfony/Component/HttpKernel/Profiler/FileProfilerStorage.php
@@ -140,7 +140,7 @@ public function write(Profile $profile)
         // Store profile
         $data = array(
             'token'    => $profile->getToken(),
-            'parent'   => $profile->getParent() ? $profile->getParent()->getToken() : null,
+            'parent'   => $profile->getParentToken(),
             'children' => array_map(function ($p) { return $p->getToken(); }, $profile->getChildren()),
             'data'     => $profile->getCollectors(),
             'ip'       => $profile->getIp(),
@@ -164,7 +164,7 @@ public function write(Profile $profile)
             $profile->getMethod(),
             $profile->getUrl(),
             $profile->getTime(),
-            $profile->getParent() ? $profile->getParent()->getToken() : null,
+            $profile->getParentToken(),
         ));
         fclose($file);
 
diff --git a/src/Symfony/Component/HttpKernel/Profiler/MongoDbProfilerStorage.php b/src/Symfony/Component/HttpKernel/Profiler/MongoDbProfilerStorage.php
@@ -90,7 +90,7 @@ public function write(Profile $profile)
 
         $record = array(
             '_id' => $profile->getToken(),
-            'parent' => $profile->getParent() ? $profile->getParent()->getToken() : null,
+            'parent' => $profile->getParentToken(),
             'data' => serialize($profile->getCollectors()),
             'ip' => $profile->getIp(),
             'method' => $profile->getMethod(),
diff --git a/src/Symfony/Component/HttpKernel/Profiler/PdoProfilerStorage.php b/src/Symfony/Component/HttpKernel/Profiler/PdoProfilerStorage.php
@@ -82,7 +82,7 @@ public function write(Profile $profile)
         $db = $this->initDb();
         $args = array(
             ':token'      => $profile->getToken(),
-            ':parent'     => $profile->getParent() ? $profile->getParent()->getToken() : '',
+            ':parent'     => $profile->getParentToken(),
             ':data'       => base64_encode(serialize($profile->getCollectors())),
             ':ip'         => $profile->getIp(),
             ':method'     => $profile->getMethod(),
diff --git a/src/Symfony/Component/HttpKernel/Profiler/Profile.php b/src/Symfony/Component/HttpKernel/Profiler/Profile.php
@@ -72,7 +72,7 @@ public function setParent(Profile $parent)
     }
 
     /**
-     * Returns the parent token.
+     * Returns the parent profile.
      *
      * @return Profile The parent profile
      */
@@ -81,6 +81,16 @@ public function getParent()
         return $this->parent;
     }
 
+    /**
+     * Returns the parent token.
+     *
+     * @return null|string The parent token
+     */
+    public function getParentToken()
+    {
+        return $this->parent ? $this->parent->getToken() : null;
+    }
+
     /**
      * Returns the IP.
      *
diff --git a/tests/Symfony/Tests/Component/HttpKernel/Profiler/FileProfilerStorageTest.php b/tests/Symfony/Tests/Component/HttpKernel/Profiler/FileProfilerStorageTest.php
@@ -85,7 +85,7 @@ public function testChildren()
 
         // Check child has link to parent
         $this->assertNotNull($childProfile->getParent());
-        $this->assertEquals($parentProfile->getToken(), $childProfile->getParent()->getToken());
+        $this->assertEquals($parentProfile->getToken(), $childProfile->getParentToken());
 
         // Check parent has child
         $children = $parentProfile->getChildren();
@@ -122,8 +122,8 @@ public function testStoreDuplicateToken()
     {
         $profile = new Profile('token');
 
-        $this->assertTrue(true === self::$storage->write($profile), '->write() returns true when the token is unique');
-        $this->assertTrue(true === self::$storage->write($profile), '->write() overwrites when the token is already present in the DB');
+        $this->assertTrue(self::$storage->write($profile), '->write() returns true when the token is unique');
+        $this->assertTrue(self::$storage->write($profile), '->write() overwrites when the token is already present in the DB');
     }
 
     public function testRetrieveByIp()

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ public function setParent(Profile $parent)`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`/**`
`75`		`- * Returns the parent token.`
	`75`	`+ * Returns the parent profile.`
`76`	`76`	`*`
`77`	`77`	`* @return Profile The parent profile`
`78`	`78`	`*/`
`@@ -81,6 +81,16 @@ public function getParent()`
`81`	`81`	`return $this->parent;`
`82`	`82`	`}`
`83`	`83`
	`84`	`+ /**`
	`85`	`+ * Returns the parent token.`
	`86`	`+ *`
	`87`	`+ * @return null\|string The parent token`
	`88`	`+ */`
	`89`	`+ public function getParentToken()`
	`90`	`+ {`
	`91`	`+ return $this->parent ? $this->parent->getToken() : null;`
	`92`	`+ }`
	`93`	`+`
`84`	`94`	`/**`
`85`	`95`	`* Returns the IP.`
`86`	`96`	`*`