Fix pydocstyle argv (python-lsp#247)

gatesn · web-flow · commit 344b7877cde0 · 2018-01-26T19:01:05.000Z
diff --git a/pyls/plugins/pydocstyle_lint.py b/pyls/plugins/pydocstyle_lint.py
@@ -1,5 +1,8 @@
 # Copyright 2017 Palantir Technologies, Inc.
+import contextlib
 import logging
+import sys
+
 import pydocstyle
 from pyls import hookimpl, lsp
 
@@ -19,8 +22,10 @@ def pyls_settings():
 @hookimpl
 def pyls_lint(document):
     conf = pydocstyle.config.ConfigurationParser()
-    conf.parse()
-    conf._arguments = [document.path]
+
+    with _patch_sys_argv([document.path]):
+        # TODO(gatesn): We can add more pydocstyle args here from our pyls config
+        conf.parse()
 
     # Will only yield a single filename, the document path
     diags = []
@@ -65,3 +70,16 @@ def _parse_diagnostic(document, error):
             }
         }
     }
+
+
+@contextlib.contextmanager
+def _patch_sys_argv(arguments):
+    old_args = sys.argv
+
+    # Preserve argv[0] since it's the executable
+    sys.argv = old_args[0:1] + arguments
+
+    try:
+        yield
+    finally:
+        sys.argv = old_args
diff --git a/setup.py b/setup.py
@@ -38,7 +38,7 @@
         'json-rpc',
         'mccabe',
         'pycodestyle',
-        'pydocstyle',
+        'pydocstyle>=2.0.0',
         'pyflakes',
         'rope>=0.10.5',
         'yapf',
