we can handle select * with selection condition

42penguins · 42penguins · commit 5973072b5b86 · 2014-02-18T12:08:22.000+01:00
diff --git a/src/backend/executor/execProcnode.c b/src/backend/executor/execProcnode.c
@@ -566,6 +566,9 @@ LookForFilterWithEquality(PlanState* result, Oid tableOid, List* qual)
 				break;
 		}
 
+		// invalid all columns of this table, because there is a selection
+		InvalidateStatisticsForTable(tableOid);
+
 		// the magic numbers are operator identifiers from posgres/src/include/catalog/pg_operator.h
 		// equals
 		if(opno == 94 || opno == 96 || opno == 410 || opno == 416 || opno == 1862 || opno == 1868 || opno == 15 || opno == 532 || opno == 533) { // it is a equality like number_of_tracks = 3
@@ -626,7 +629,7 @@ LookForFilterWithEquality(PlanState* result, Oid tableOid, List* qual)
 		else {
 			printf("this opno is no =, <, >, <= or >=: %d (for column id %d)\n", opno, columnId);
 			// found a selection, therefore we cannot use old statistics
-			InvalidateStatisticsForTable(tableOid);
+			// InvalidateStatisticsForTable(tableOid); (this has to be always, because there could be more than one column of this table in the result
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -566,6 +566,9 @@ LookForFilterWithEquality(PlanState* result, Oid tableOid, List* qual)`
`566`	`566`	`break;`
`567`	`567`	`}`
`568`	`568`
	`569`	`+ // invalid all columns of this table, because there is a selection`
	`570`	`+ InvalidateStatisticsForTable(tableOid);`
	`571`	`+`
`569`	`572`	`// the magic numbers are operator identifiers from posgres/src/include/catalog/pg_operator.h`
`570`	`573`	`// equals`
`571`	`574`	`if(opno == 94 \|\| opno == 96 \|\| opno == 410 \|\| opno == 416 \|\| opno == 1862 \|\| opno == 1868 \|\| opno == 15 \|\| opno == 532 \|\| opno == 533) { // it is a equality like number_of_tracks = 3`
`@@ -626,7 +629,7 @@ LookForFilterWithEquality(PlanState* result, Oid tableOid, List* qual)`
`626`	`629`	`else {`
`627`	`630`	`printf("this opno is no =, <, >, <= or >=: %d (for column id %d)\n", opno, columnId);`
`628`	`631`	`// found a selection, therefore we cannot use old statistics`
`629`		`- InvalidateStatisticsForTable(tableOid);`
	`632`	`+ // InvalidateStatisticsForTable(tableOid); (this has to be always, because there could be more than one column of this table in the result`
`630`	`633`	`}`
`631`	`634`	`}`
`632`	`635`	`}`