8000 Support custom httpx client creation by nickcoai · Pull Request #752 · modelcontextprotocol/python-sdk · GitHub
[go: up one dir, main page]
Skip to content

Support custo 8000 m httpx client creation #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 23, 2025
Merged

Support custom httpx client creation #752

merged 3 commits into from
May 23, 2025

Conversation

nickcoai
Copy link
Contributor

Motivation and Context

Currently the SDK defaults imply certain properties for httpx clients, two notable ones are redirect policies as well as proxies. To support various security configurations instead make the client wholly injectable. This avoids clients needing to fork the entire transport method.

How Has This Been Tested?

Tested locally with a fake client.

Breaking Changes

None.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

N/A

@fabioyamate fabioyamate mentioned this pull request May 19, 2025
Closed
9 tasks
@ihrpr ihrpr modified the milestones: r-05-25, HPR May 19, 2025
@nickcoai
Merge branch 'main' into nickc/inject
2f9fc89 
# Conflicts:
#	src/mcp/client/sse.py
#	src/mcp/client/streamable_http.py
ihrpr
ihrpr approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor
@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Would be great to add instruction to README as well

@ihrpr ihrpr mentioned this pull request May 23, 2025
Closed
9 tasks
@ihrpr ihrpr merged commit 10cf0f7 into modelcontextprotocol:main May 23, 2025
10 checks passed
This was referenced May 23, 2025
Closed
Closed
@juan-abia juan-abia mentioned this pull request May 26, 2025
Merged
@Kludex
Copy link
Member
Kludex commented Jun 2, 2025

It would have been better to pass the client itself...

@rumperto
Copy link
rumperto commented Jun 3, 2025 •
edited
Loading

It would have been better to pass the client itself...

Agree with this

@rumperto
Copy link
rumperto commented Jun 3, 2025

A new unit test would have been nice too.

@Kludex
Copy link
Member
Kludex commented Jun 11, 2025

And now I notice that the timeout parameter is not even included in the call to the callback... 😞

@ihrpr
Copy link
Contributor
ihrpr commented Jun 11, 2025

And now I notice that the timeout parameter is not even included in the call to the callback... 😞

it's not in sse, but in general is there, am I missing something?

@Kludex
Copy link
Member
Kludex commented Jun 11, 2025

And now I notice that the timeout parameter is not even included in the call to the callback... 😞

it's not in sse, but in general is there, am I missing something?

Ah, I missed that, sorry.

That said, on the sse, we use the client, so you can actually pass the timeout to the client before using the aconnect_sse. Can't we?

@ihrpr
Copy link
Contributor
ihrpr commented Jun 11, 2025

And now I notice that the timeout parameter is not even included in the call to the callback... 😞

it's not in sse, but in general is there, am I missing something?

Ah, I missed that, sorry.

That said, on the sse, we use the client, so you can actually pass the timeout to the client before using the aconnect_sse. Can't we?

yes, we should, I can just add this as there were a couple of PRs and issues about it

@ihrpr ihrpr mentioned this pull request Jun 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihrpr ihrpr ihrpr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
HPR
Development

Successfully merging this pull request may close these issues.
4 participants
@nickcoai @Kludex @rumperto @ihrpr
0