10000 Fix lint issues · modelcontextprotocol/python-sdk@27e5b12 · GitHub
[go: up one dir, main page]

Skip to content

Commit 27e5b12

Browse files
committed
Fix lint issues
1 parent 85036e0 commit 27e5b12

File tree

1 file changed

+12
-17
lines changed

1 file changed

+12
-17
lines changed

src/mcp/client/config/mcp_servers_config.py

Lines changed: 12 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import re
77
import shlex
88
from pathlib import Path
9-
from typing import Annotated, Any, Literal
9+
from typing import Annotated, Any, Literal, cast
1010

1111
# third party imports
1212
try:
@@ -141,11 +141,7 @@ def validate_inputs(self, provided_inputs: dict[str, str]) -> list[str]:
141141
return []
142142

143143
required_input_ids = self.get_required_inputs()
144-
missing_inputs = []
145-
146-
for input_id in required_input_ids:
147-
if input_id not in provided_inputs:
148-
missing_inputs.append(input_id)
144+
missing_inputs = [input_id for input_id in required_input_ids if input_id not in provided_inputs]
149145

150146
return missing_inputs
151147

@@ -175,24 +171,23 @@ def replace_input(match: re.Match[str]) -> str:
175171
return re.sub(r"\$\{input:([^}]+)\}", replace_input, data)
176172

177173
elif isinstance(data, dict):
178-
result = {} # type: ignore
179-
for k, v in data.items(): # type: ignore
180-
result[k] = cls._substitute_inputs(v, inputs) # type: ignore
181-
return result
174+
dict_result: dict[str, Any] = {}
175+
dict_data = cast(dict[str, Any], data)
176+
for k, v in dict_data.items():
177+
dict_result[k] = cls._substitute_inputs(v, inputs)
178+
return dict_result
182179

183180
elif isinstance(data, list):
184-
result = [] # type: ignore
185-
for item in data: # type: ignore
186-
result.append(cls._substitute_inputs(item, inputs)) # type: ignore
187-
return result
181+
list_data = cast(list[Any], data)
182+
return [cls._substitute_inputs(item, inputs) for item in list_data]
188183

189184
else:
190185
return data
191186

192187
@classmethod
193188
def _strip_json_comments(cls, content: str) -> str:
194189
"""Strip // comments from JSON content, being careful not to remove // inside strings."""
195-
result = []
190+
result: list[str] = []
196191
lines = content.split("\n")
197192

198193
for line in lines:
@@ -266,12 +261,12 @@ def from_file(
266261
if inputs is not None and preliminary_config.inputs:
267262
missing_inputs = preliminary_config.validate_inputs(inputs)
268263
if missing_inputs:
269-
descriptions = []
264+
descriptions: list[str] = []
270265
for input_id in missing_inputs:
271266
desc = preliminary_config.get_input_description(input_id)
272267
descriptions.append(f" - {input_id}: {desc or 'No description'}")
273268

274-
raise ValueError(f"Missing required input values:\n" + "\n".join(descriptions))
269+
raise ValueError("Missing required input values:\n" + "\n".join(descriptions))
275270

276271
# Substitute input placeholders if inputs provided
277272
if inputs:

0 commit comments

Comments
 (0)
0