From 64b3b13576454db278ac5fab219062436e63e1d3 Mon Sep 17 00:00:00 2001 From: Radostin Stoyanov Date: Thu, 20 Dec 2018 17:43:18 +0000 Subject: [PATCH] Enable checkpoint/restore of containers with tty CRIU supports checkpoint and restore of tty devices since version 2.12 which was released on 8th of March 2017. Support for this functionality was implemented with opencontainers/runc@1c43d09 (checkpoint: add support for containers with terminals) and containerd/containerd@60daa41 (Allow to checkpoint and restore a container with console). Therefore, we can enable the support in moby/docker. Signed-off-by: Radostin Stoyanov --- daemon/checkpoint.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/daemon/checkpoint.go b/daemon/checkpoint.go index 0a0d4bf394cb6..2d7f8a7624b5d 100644 --- a/daemon/checkpoint.go +++ b/daemon/checkpoint.go @@ -63,10 +63,6 @@ func (daemon *Daemon) CheckpointCreate(name string, config types.CheckpointCreat return fmt.Errorf("Container %s not running", name) } - if container.Config.Tty { - return fmt.Errorf("checkpoint not support on containers with tty") - } - if !validCheckpointNamePattern.MatchString(config.CheckpointID) { return fmt.Errorf("Invalid checkpoint ID (%s), only %s are allowed", config.CheckpointID, validCheckpointNameChars) }