Allow commits on any unparented branch

jamill · nulltoken · commit 813be8d71992 · 2013-03-02T08:16:54.000+01:00
diff --git a/LibGit2Sharp.Tests/CommitFixture.cs b/LibGit2Sharp.Tests/CommitFixture.cs
@@ -814,5 +814,28 @@ public void CanCorrectlyDistinguishAuthorFromCommitter()
                 Assert.Equal(committer, c.Committer);
             }
         }
+
+        [Fact]
+        public void CanCommitOnOrphanedBranch()
+        {
+            string newBranchName = "refs/heads/newBranch";
+            SelfCleaningDirectory scd = BuildSelfCleaningDirectory();
+
+            using (var repo = Repository.Init(scd.DirectoryPath))
+            {
+                // Set Head to point to branch other than master
+                repo.Refs.UpdateTarget("HEAD", newBranchName);
+                Assert.Equal(newBranchName, repo.Head.CanonicalName);
+
+                const string relativeFilepath = "test.txt";
+                string filePath = Path.Combine(repo.Info.WorkingDirectory, relativeFilepath);
+
+                File.WriteAllText(filePath, "test\n");
+                repo.Index.Stage(relativeFilepath);
+
+                repo.Commit("Initial commit", DummySignature, DummySignature);
+                Assert.Equal(1, repo.Head.Commits.Count());
+            }
+        }
     }
 }
diff --git a/LibGit2Sharp/Repository.cs b/LibGit2Sharp/Repository.cs
@@ -697,7 +697,7 @@ private IEnumerable<Commit> RetrieveParentsOfTheCommitBeingCreated(bool amendPre
                 return Head.Tip.Parents;
             }
 
-            if (Info.IsEmpty)
+            if (Info.IsHeadOrphaned)
             {
                 return Enumerable.Empty<Commit>();
             }

Original file line number	Diff line number	Diff line change
`@@ -697,7 +697,7 @@ private IEnumerable<Commit> RetrieveParentsOfTheCommitBeingCreated(bool amendPre`
`697`	`697`	`return Head< 5F81 span class=pl-kos>.Tip.Parents;`
`698`	`698`	`}`
`699`	`699`
`700`		`- if (Info.IsEmpty)`
	`700`	`+ if (Info.IsHeadOrphaned)`
`701`	`701`	`{`
`702`	`702`	`return Enumerable.Empty<Commit>();`
`703`	`703`	`}`